From owner-cvs-src@FreeBSD.ORG  Sun Nov 14 21:40:48 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 56AFB16A4CE; Sun, 14 Nov 2004 21:40:48 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6F3C243D3F; Sun, 14 Nov 2004 21:40:47 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iAELejW2057114;
	Sun, 14 Nov 2004 22:40:45 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Marcel Moolenaar <marcel@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sun, 14 Nov 2004 21:38:22 GMT."
             <200411142138.iAELcM5h018562@repoman.freebsd.org> 
Date: Sun, 14 Nov 2004 22:40:45 +0100
Message-ID: <57113.1100468445@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/uart uart_subr.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Nov 2004 21:40:48 -0000

In message <200411142138.iAELcM5h018562@repoman.freebsd.org>, Marcel Moolenaar 
writes:
>marcel      2004-11-14 21:38:22 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/dev/uart         uart_subr.c 
>  Log:
>  Make sure the baudrate specified with the BR tag is somewhat sane.
>  A baudrate we consider insane is silently replaced with 0. When the
>  baudrate is 0, we will not try to program the hardware. Instead we
>  leave the communication speed unaltered, maximizing the chance to
>  have a working console. Obviously this means we allow specifying a
>  0 baudrate for exactly that purpose.

Setting a zero speed used to have magic meaning, sometimes sending
a break, on other systems it would hang up the line.  Overloading
with yet a meaning may not be a good idea.  (I'm not sure what
the standards demand btw).

How about using -1 instead ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.