From owner-freebsd-current  Sat Jun 24 16:57:18 2000
Delivered-To: freebsd-current@freebsd.org
Received: from assaris.sics.se (assaris.sics.se [193.10.66.234])
	by hub.freebsd.org (Postfix) with ESMTP
	id DCC2D37B697; Sat, 24 Jun 2000 16:57:12 -0700 (PDT)
	(envelope-from assar@assaris.sics.se)
Received: (from assar@localhost)
	by assaris.sics.se (8.9.3/8.9.3) id BAA97737;
	Sun, 25 Jun 2000 01:57:21 +0200 (CEST)
	(envelope-from assar)
To: Warner Losh <imp@village.org>
Cc: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>,
	current@FreeBSD.ORG, kris@FreeBSD.ORG
Subject: Re: vnode_if.h: how should it be done ?
References: <5llmzyqsfm.fsf@assaris.sics.se> <5ln1kesdkq.fsf@assaris.sics.se> <200006220345.XAA42447@khavrinen.lcs.mit.edu> <200006240610.AAA01831@harmony.village.org>
From: Assar Westerlund <assar@sics.se>
Date: 25 Jun 2000 01:57:20 +0200
In-Reply-To: Warner Losh's message of "Sat, 24 Jun 2000 00:10:14 -0600"
Message-ID: <5lwvjetyxr.fsf@assaris.sics.se>
Lines: 36
User-Agent: Gnus/5.070098 (Pterodactyl Gnus v0.98) Emacs/20.6
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Warner Losh <imp@village.org> writes:
> In message <5llmzyqsfm.fsf@assaris.sics.se> Assar Westerlund writes:
> : The problem is that the source files are hidden in the kernel source
> : directory and not installed.  Where should vnode_if.{src,pl} get
> : installed?  It seems much simpler just to install vnode_if.h in
> : /usr/include/sys.  Patch appended.
> 
> No.  

> We don't install kenrel internal files.

But it's not kernel internal.  It's used by modules/KLDs ?  Where
should these expect to find it?

> Use SYSDIR instead.

I'm not sure what you mean by this?  Should vnode_if.h just reside in
/sys/sys and be used from there or what?

> : +	${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 \
> : +		${.OBJDIR}/vnode_if.h \
> : +		${DESTDIR}/usr/include/sys
> 
> I object to this part of the patch.  We shouldn't install this file.
> It isn't needed by anything outside of the kernel/drivers.

Well, depends on your point of view if that's outside kernel/drivers,
but it's sure used by modules/KLDs.

> For drivers, it should be built automatically as part of the modules
> build system ala the *_if.m stuff.

Where are these files installed so that they can be used by
third-party KLDs?

/assar


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message