Date: Sun, 12 Nov 1995 14:27:57 +0100 (MET) From: Andreas Klemm <andreas@knobel.gun.de> To: hackers@freebsd.org, current@freebsd.org Subject: Diffs to the dump utility, rewritten with respect to your comments Message-ID: <Pine.BSF.3.91.951112135348.4791A-200000@knobel.gun.de>
next in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.
--0-895630724-816182877=:4791
Content-Type: TEXT/PLAIN; charset=US-ASCII
Hi !
Here again my diffs for the dump utility. I rewrote my changes
because of your comments (division through zero, same default
dump device as tar). I made the context diffs against the
FreeBSD-stable source of today: Sun Nov 12 14:01:21 MET 1995.
Changes in detail:
main.c - line 167:
abort dump if a blocksize > 32 (K) was chosen using
dump's "b" option, because restore is unable to restore
dumps with blocksizes over 32 K. Someone said here,
there might be a bug in the scsi tape driver. This
should be fixed as soon as possible.
Users/Administrators are now protected from the worst
case situation, that they can't restore their dump if
they choosed a blocksize over 32. Dump does it all fine,
but later, &@&%" ;-) "So this patch prevent's dump from
being a BOFH tool ;-))"
- line 447:
here ends the dump time, needed for calculation of
dumptime and throughput.
- line 460:
report dump time and performance after dump.
check that dumptime isn't zero, that would
cause a division through zero. when calculating
the performance.
dump.h - line 82:
introducnd new variable for dumptime calculation
tend_writing.
dump.8 - line 105:
changed default dump device to /dev/rst0. Now it's
the same as in tar (for Joerg ;-). He convinced me,
that a) not all people have a dump device, where
everything fits on one tape and b) that /dev/rst0
is the standard in tar, too. Ok, you win ;-))
- line 259:
In the example I deceided to dump to the
first connected tape drive, most people will
have only one tape device, so the example becomes
more praxis oriented ;-)
- line 285:
FILES section: changed /dev/rmt8 to /dev/rst0
- line 314:
BUG section: tell the people to use blocksizes
<= 32 K. If they don't follow that, then dump
takes care and aborts ;-) Never do backups, you
can't read ;-)
- line 341:
Updated the history section.
pathnames.h - line 38:
changed default dump device to /dev/rst0
That's it folks, hope you enjoyed it. I hope the verbose comments
help, to incorporate these (partly important) fixes to the source
tree very quickly.
I think the fix that prevents to use blocksizes over 32k, is
really important. Figure out, someone relies on the backup,
that he made on his brand new Tape or DAT ... Let's assume,
he makes two backups, to be save, but he too lazy or
inexperienced, to check, if he can read it in....
If then the system crashes and he is unable to restore his
data, then ..... figure out yourself ! Perhaps this might
be a reason, to "break" the code freeze in this case.
A System, that is unable to read it's own dumps under certain
circumstances without a big warning to the operator is deadly bad ;-)
Think over it twice, it was called FreeBSD-stable the last weeks ;-)
Prevent calling it: "FreeBSD-crashed-unable_to_restore" ;-))
happy weekend :)
Andreas ///
--
andreas@knobel.gun.de /\/\___ Wiechers & Partner Datentechnik GmbH
Andreas Klemm ___/\/\/ - Support Unix - aklemm@wup.de -
\/
ftp://sunsite.unc.edu/pub/Linux/system/Printing/aps-491.tgz
apsfilter - magic print filter 4lpd >>> knobel is powered by FreeBSD <<<
--0-895630724-816182877=:4791
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="diff.akl"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.BSF.3.91.951112142757.4791B@knobel.gun.de>
Content-Description: diffs to dump(8) FreeBSD-stable
KioqIG1haW4uYy5vcmlnCVN1biBOb3YgMTIgMTM6NDE6NDMgMTk5NQ0KLS0t
IG1haW4uYwlTdW4gTm92IDEyIDEzOjQ0OjE5IDE5OTUNCioqKioqKioqKioq
KioqKg0KKioqIDE2NywxNzIgKioqKg0KLS0tIDE2NywxNzkgLS0tLQ0KICAJ
CWNhc2UgJ2InOgkJLyogYmxvY2tzIHBlciB0YXBlIHdyaXRlICovDQogIAkJ
CW50cmVjID0gbnVtYXJnKCdiJywgIm51bWJlciBvZiBibG9ja3MgcGVyIHdy
aXRlIiwNCiAgCQkJICAgIDFMLCAxMDAwTCwgJmFyZ2MsICZhcmd2KTsNCisg
CQkJLyogWFhYIHJlc3RvcmUgaXMgdW5hYmxlIHRvIHJlc3RvcmUgZHVtcHMg
dGhhdCANCisgCQkJICAgd2VyZSBjcmVhdGVkICB3aXRoIGEgYmxvY2tzaXpl
IGxhcmdlciB0aGFuIDMySy4NCisgCQkJICAgUG9zc2libHkgYnVnIGluIHRo
ZSBzY3NpIHRhcGUgZHJpdmVyLiBBS0wgKi8NCisgCQkJaWYgKCBudHJlYyA+
IDMyICkgew0KKyAJCQkJbXNnKCJwbGVhc2UgY2hvb3NlIGEgYmxvY2tzaXpl
IDw9IDMyXG4iKTsNCisgCQkJCWV4aXQoWF9BQk9SVCk7DQorIAkJCX0NCiAg
CQkJYnJlYWs7DQogIA0KICAJCWNhc2UgJ0InOgkJLyogYmxvY2tzIHBlciBv
dXRwdXQgZmlsZSAqLw0KKioqKioqKioqKioqKioqDQoqKiogNDQwLDQ0NSAq
KioqDQotLS0gNDQ3LDQ1MyAtLS0tDQogIAkJKHZvaWQpZHVtcGlubyhkcCwg
aW5vKTsNCiAgCX0NCiAgDQorIAkodm9pZCl0aW1lKCh0aW1lX3QgKikmKHRl
bmRfd3JpdGluZykpOwkJLyogQUtMIGVuZCB0aW1lICovDQogIAlzcGNsLmNf
dHlwZSA9IFRTX0VORDsNCiAgCWZvciAoaSA9IDA7IGkgPCBudHJlYzsgaSsr
KQ0KICAJCXdyaXRlaGVhZGVyKG1heGlubyAtIDEpOw0KKioqKioqKioqKioq
KioqDQoqKiogNDQ4LDQ1MyAqKioqDQotLS0gNDU2LDQ3MSAtLS0tDQogIAll
bHNlDQogIAkJbXNnKCJEVU1QOiAlbGQgdGFwZSBibG9ja3Mgb24gJWQgdm9s
dW1lcyhzKVxuIiwNCiAgCQkgICAgc3BjbC5jX3RhcGVhLCBzcGNsLmNfdm9s
dW1lKTsNCisgDQorIAkvKiBBS0w6IHJlcG9ydCBkdW1wIHBlcmZvcm1hbmNl
LCBhdm9pZCBkaXZpc2lvbiB0aHJvdWdoIHplcm8gKi8NCisgCWlmKHRlbmRf
d3JpdGluZy10c3RhcnRfd3JpdGluZyA9PSAwKQ0KKyAJCW1zZygiRFVNUDog
ZmluaXNoZWQgaW4gJWQgc2Vjb25kc1xuIiwNCisgCQkJdGVuZF93cml0aW5n
LXRzdGFydF93cml0aW5nKTsNCisgCWVsc2UNCisgCQltc2coIkRVTVA6IGZp
bmlzaGVkIGluICVkIHNlY29uZHMsIHRocm91Z2hwdXQgJWQgS0J5dGVzL3Nl
Y1xuIiwNCisgCQkJdGVuZF93cml0aW5nLXRzdGFydF93cml0aW5nLA0KKyAJ
CQlzcGNsLmNfdGFwZWEvKHRlbmRfd3JpdGluZy10c3RhcnRfd3JpdGluZykp
Ow0KKyANCiAgCXB1dGR1bXB0aW1lKCk7DQogIAl0cmV3aW5kKCk7DQogIAli
cm9hZGNhc3QoIkRVTVAgSVMgRE9ORSFcN1w3XG4iKTsNCioqKiBkdW1wLmgu
b3JpZwlTdW4gTm92IDEyIDEzOjQxOjQzIDE5OTUNCi0tLSBkdW1wLmgJU3Vu
IE5vdiAxMiAxMzo0NDoxOSAxOTk1DQoqKioqKioqKioqKioqKioNCioqKiA3
OSw4NCAqKioqDQotLS0gNzksODUgLS0tLQ0KICBpbnQJYmxvY2tzd3JpdHRl
bjsJLyogbnVtYmVyIG9mIGJsb2NrcyB3cml0dGVuIG9uIGN1cnJlbnQgdGFw
ZSAqLw0KICBpbnQJdGFwZW5vOwkJLyogY3VycmVudCB0YXBlIG51bWJlciAq
Lw0KICB0aW1lX3QJdHN0YXJ0X3dyaXRpbmc7CS8qIHdoZW4gc3RhcnRlZCB3
cml0aW5nIHRoZSBmaXJzdCB0YXBlIGJsb2NrICovDQorIHRpbWVfdAl0ZW5k
X3dyaXRpbmc7CS8qIGFmdGVyIHdyaXRpbmcgdGhlIGxhc3QgdGFwZSBibG9j
ayBBS0wgKi8NCiAgc3RydWN0CWZzICpzYmxvY2s7CS8qIHRoZSBmaWxlIHN5
c3RlbSBzdXBlciBibG9jayAqLw0KICBjaGFyCXNibG9ja19idWZbTUFYQlNJ
WkVdOw0KICBsb25nCWRldl9ic2l6ZTsJLyogYmxvY2sgc2l6ZSBvZiB1bmRl
cmx5aW5nIGRpc2sgZGV2aWNlICovDQoqKiogZHVtcC44Lm9yaWcJU3VuIE5v
diAxMiAxMzo0MTo0MyAxOTk1DQotLS0gZHVtcC44CVN1biBOb3YgMTIgMTM6
NDQ6MTkgMTk5NQ0KKioqKioqKioqKioqKioqDQoqKiogMTAyLDEwOCAqKioq
DQogIC5BciBmaWxlDQogIG1heSBiZSBhIHNwZWNpYWwgZGV2aWNlIGZpbGUN
CiAgbGlrZQ0KISAuUGEgL2Rldi9ybXQxMg0KICAoYSB0YXBlIGRyaXZlKSwN
CiAgLlBhIC9kZXYvcnNkMWMNCiAgKGEgZGlzayBkcml2ZSksDQotLS0gMTAy
LDEwOCAtLS0tDQogIC5BciBmaWxlDQogIG1heSBiZSBhIHNwZWNpYWwgZGV2
aWNlIGZpbGUNCiAgbGlrZQ0KISAuUGEgL2Rldi9yc3QwDQogIChhIHRhcGUg
ZHJpdmUpLA0KICAuUGEgL2Rldi9yc2QxYw0KICAoYSBkaXNrIGRyaXZlKSwN
CioqKioqKioqKioqKioqKg0KKioqIDI1NiwyNjIgKioqKg0KICAuSXQNCiAg
QWx3YXlzIHN0YXJ0IHdpdGggYSBsZXZlbCAwIGJhY2t1cCwgZm9yIGV4YW1w
bGU6DQogIC5CZCAtbGl0ZXJhbCAtb2Zmc2V0IGluZGVudA0KISAvc2Jpbi9k
dW1wIDB1ZiAvZGV2L25yc3QxIC91c3Ivc3JjDQogIC5FZA0KICAuUHANCiAg
VGhpcyBzaG91bGQgYmUgZG9uZSBhdCBzZXQgaW50ZXJ2YWxzLCBzYXkgb25j
ZSBhIG1vbnRoIG9yIG9uY2UgZXZlcnkgdHdvIG1vbnRocywNCi0tLSAyNTYs
MjYyIC0tLS0NCiAgLkl0DQogIEFsd2F5cyBzdGFydCB3aXRoIGEgbGV2ZWwg
MCBiYWNrdXAsIGZvciBleGFtcGxlOg0KICAuQmQgLWxpdGVyYWwgLW9mZnNl
dCBpbmRlbnQNCiEgL3NiaW4vZHVtcCAwdWYgL2Rldi9ucnN0MCAvdXNyL3Ny
Yw0KICAuRWQNCiAgLlBwDQogIFRoaXMgc2hvdWxkIGJlIGRvbmUgYXQgc2V0
IGludGVydmFscywgc2F5IG9uY2UgYSBtb250aCBvciBvbmNlIGV2ZXJ5IHR3
byBtb250aHMsDQoqKioqKioqKioqKioqKioNCioqKiAyODIsMjg4ICoqKioN
CiAgcm90YXRlZCBvdXQgb2YgdGhlIGR1bXAgY3ljbGUgYW5kIGZyZXNoIHRh
cGVzIGJyb3VnaHQgaW4uDQogIC5TaCBGSUxFUw0KICAuQmwgLXRhZyAtd2lk
dGggL2V0Yy9kdW1wZGF0ZXMgLWNvbXBhY3QNCiEgLkl0IFBhIC9kZXYvcm10
OA0KICBkZWZhdWx0IHRhcGUgdW5pdCB0byBkdW1wIHRvDQogIC5JdCBQYSAv
ZXRjL2R1bXBkYXRlcw0KICBkdW1wIGRhdGUgcmVjb3Jkcw0KLS0tIDI4Miwy
ODggLS0tLQ0KICByb3RhdGVkIG91dCBvZiB0aGUgZHVtcCBjeWNsZSBhbmQg
ZnJlc2ggdGFwZXMgYnJvdWdodCBpbi4NCiAgLlNoIEZJTEVTDQogIC5CbCAt
dGFnIC13aWR0aCAvZXRjL2R1bXBkYXRlcyAtY29tcGFjdA0KISAuSXQgUGEg
L2Rldi9yc3QwDQogIGRlZmF1bHQgdGFwZSB1bml0IHRvIGR1bXAgdG8NCiAg
Lkl0IFBhIC9ldGMvZHVtcGRhdGVzDQogIGR1bXAgZGF0ZSByZWNvcmRzDQoq
KioqKioqKioqKioqKioNCioqKiAzMTEsMzE2ICoqKioNCi0tLSAzMTEsMzIw
IC0tLS0NCiAgcmVlbHMgYWxyZWFkeSB3cml0dGVuIGp1c3QgaGFuZyBhcm91
bmQgdW50aWwgdGhlIGVudGlyZSB0YXBlDQogIGlzIHdyaXR0ZW4uDQogIC5Q
cA0KKyByZXN0b3JlKDgpIGlzIGN1cnJlbnRseSB1bmFibGUgdG8gcmVzdG9y
ZSBkdW1wcyB0aGF0IHdlcmUgY3JlYXRlZA0KKyB3aXRoIGEgYmxvY2tzaXpl
IGxhcmdlciB0aGFuIDMyLiBXb3JrYXJvdW5kIGZvciBzYWZldHkgcmVhc29u
czogDQorIGR1bXAgYWJvcnRzIHdpdGggYSB3YXJuaW5nIG1lc3NhZ2Ugd2hl
biBjaG9vc2luZyBhIGJsb2Nrc2l6ZSA+IDMyLg0KKyAuUHANCiAgLk5tIER1
bXANCiAgd2l0aCB0aGUNCiAgLkNtIFcNCioqKioqKioqKioqKioqKg0KKioq
IDMzNCwzMzYgKioqKg0KLS0tIDMzOCwzNTAgLS0tLQ0KICBBDQogIC5ObSBk
dW1wDQogIGNvbW1hbmQgYXBwZWFyZWQgaW4gVmVyc2lvbiA2IEFUJlQgVU5J
WC4NCisgLlBwDQorIEFkZGl0aW9uYWwgZHVtcCBtZXNzYWdlIChzaW1pbGFy
IHRvIFNvbGFyaXMgMikgDQorIGJ5IEFuZHJlYXMgS2xlbW0gPGFuZHJlYXNA
a25vYmVsLmd1bi5kZT4gcmVwb3J0aW5nIA0KKyAuTm0gYmFja3VwIHRpbWUN
CisgaW4gc2Vjb25kcyBhbmQNCisgLk5tIHdyaXRlIHBlcmZvcm1hbmNlIA0K
KyBpbiBLYnl0ZXMgcGVyIHNlY29uZC4gQ2hhbmdlZCBkZWZhdWx0IGR1bXAg
ZGV2aWNlIGZyb20NCisgdGhlIG9sZCBmYXNoaW9uZWQgcm10OCBkZXZpY2Ug
dG8gL2Rldi9yc3QwIChzbyBpdCdzIHRoZSBzYW1lDQorIGFzIHVzZWQgYnkg
dGFyKS4NCisgQXBwZWFyZWQgZmlyc3QgaW4gRnJlZUJTRCAyLjIuDQoqKiog
cGF0aG5hbWVzLmgub3JpZwlTdW4gTm92IDEyIDEzOjQxOjQzIDE5OTUNCi0t
LSBwYXRobmFtZXMuaAlTdW4gTm92IDEyIDEzOjQ0OjE5IDE5OTUNCioqKioq
KioqKioqKioqKg0KKioqIDM1LDQxICoqKioNCiAgDQogICNpbmNsdWRlIDxw
YXRocy5oPg0KICANCiEgI2RlZmluZQlfUEFUSF9ERUZUQVBFCSIvZGV2L3Jt
dDgiDQogICNkZWZpbmUJX1BBVEhfRFRNUAkiL2V0Yy9kdG1wIg0KICAjZGVm
aW5lCV9QQVRIX0RVTVBEQVRFUwkiL2V0Yy9kdW1wZGF0ZXMiDQogICNkZWZp
bmUJX1BBVEhfTE9DSwkiL3RtcC9kdW1wbG9ja1hYWFhYWCINCi0tLSAzNSw0
MSAtLS0tDQogIA0KICAjaW5jbHVkZSA8cGF0aHMuaD4NCiAgDQohICNkZWZp
bmUJX1BBVEhfREVGVEFQRQkiL2Rldi9yc3QwIgkvKiBBS0wgKi8NCiAgI2Rl
ZmluZQlfUEFUSF9EVE1QCSIvZXRjL2R0bXAiDQogICNkZWZpbmUJX1BBVEhf
RFVNUERBVEVTCSIvZXRjL2R1bXBkYXRlcyINCiAgI2RlZmluZQlfUEFUSF9M
T0NLCSIvdG1wL2R1bXBsb2NrWFhYWFhYIg0K
--0-895630724-816182877=:4791--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.91.951112135348.4791A-200000>