Date: Sun, 19 Nov 2006 16:46:10 -0800 (PST) From: mjacob@freebsd.org To: Attilio Rao <attilio@freebsd.org> Cc: freebsd-scsi@freebsd.org Subject: Re: a code reduction function addition to cam_xpt Message-ID: <20061119164455.I44297@ns1.feral.com> In-Reply-To: <3bbf2fe10611191631h6883b862uf8088533913a7bc6@mail.gmail.com> References: <20061119161631.L44297@ns1.feral.com> <3bbf2fe10611191631h6883b862uf8088533913a7bc6@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> Would not be better a preprocessing stub?
>
> something like:
>
> #define XPT_PRINT(path, fmt, ...) do {
> \
> xpt_print_path(path);
> \
> printf(fmt, __VA_ARGS__);
> \
> } while (0)
>
Well, it's uglier (IMO0, doesn't get formal checking (which I forgot to
add to the define in cam_xpt.h), and you can't port it to systems that
have an older compiler. Other than that, it's probably better.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061119164455.I44297>