From owner-freebsd-bugs Wed Sep 4 13:30: 7 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D48FD37B400 for ; Wed, 4 Sep 2002 13:30:02 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3CAF843E65 for ; Wed, 4 Sep 2002 13:30:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g84KU2JU029699 for ; Wed, 4 Sep 2002 13:30:02 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g84KU1vg029698; Wed, 4 Sep 2002 13:30:01 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C87CB37B400 for ; Wed, 4 Sep 2002 13:28:40 -0700 (PDT) Received: from www.freebsd.org (www.FreeBSD.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8492D43E72 for ; Wed, 4 Sep 2002 13:28:40 -0700 (PDT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.12.4/8.12.4) with ESMTP id g84KSeOT090666 for ; Wed, 4 Sep 2002 13:28:40 -0700 (PDT) (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.4/8.12.4/Submit) id g84KSelW090665; Wed, 4 Sep 2002 13:28:40 -0700 (PDT) Message-Id: <200209042028.g84KSelW090665@www.freebsd.org> Date: Wed, 4 Sep 2002 13:28:40 -0700 (PDT) From: GB Clark To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-1.0 Subject: misc/42422: dbm_delete returns -1 instead of 1 when the key does not exist in the database. Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 42422 >Category: misc >Synopsis: dbm_delete returns -1 instead of 1 when the key does not exist in the database. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Sep 04 13:30:01 PDT 2002 >Closed-Date: >Last-Modified: >Originator: GB Clark >Release: 4.6-STABLE >Organization: VSS >Environment: FreeBSD prime.vsservices.com 4.6-STABLE FreeBSD 4.6-STABLE #0: Thu Aug 22 01:29:14 CDT 2002 gclarkii@prime.vsservices.com:/1002/objtree/usr/src/sys/PRIME i386 >Description: dbm_delete is documented to return 1 if the key does NOT exist in the dbm file. In lib/libc/db/ndmb.c it returns -1 or 0 only. >How-To-Repeat: Try to delete a non-exist key and get -1 instead of 1 using dbm_delete. >Fix: have dbm_delete in lib/libc/db/ndbm.c return status instead of the if switch. The original db delete function returns the SAME status codes as dbm_delete according to the man page for db. >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message