From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Nov 10 09:00:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B5A1AC9B for ; Sun, 10 Nov 2013 09:00:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 95F8B2E42 for ; Sun, 10 Nov 2013 09:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rAA90026090686 for ; Sun, 10 Nov 2013 09:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rAA900EY090684; Sun, 10 Nov 2013 09:00:00 GMT (envelope-from gnats) Resent-Date: Sun, 10 Nov 2013 09:00:00 GMT Resent-Message-Id: <201311100900.rAA900EY090684@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Horia Racoviceanu Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id BEA64C1B for ; Sun, 10 Nov 2013 08:50:02 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AD4A12DE1 for ; Sun, 10 Nov 2013 08:50:02 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id rAA8o2h7090444 for ; Sun, 10 Nov 2013 08:50:02 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id rAA8o2Q5090435; Sun, 10 Nov 2013 08:50:02 GMT (envelope-from nobody) Message-Id: <201311100850.rAA8o2Q5090435@oldred.freebsd.org> Date: Sun, 10 Nov 2013 08:50:02 GMT From: Horia Racoviceanu To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/183836: Update audio/flac for OGG as option [PATCH] X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Nov 2013 09:00:00 -0000 >Number: 183836 >Category: ports >Synopsis: Update audio/flac for OGG as option [PATCH] >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Nov 10 09:00:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Horia Racoviceanu >Release: FreeBSD 9.1-RELEASE amd64 >Organization: >Environment: FreeBSD horia.lan 9.1-RELEASE-p7 FreeBSD 9.1-RELEASE-p7 #0: Mon Sep 9 21:34:37 UTC 2013 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64 >Description: Add ogg depend as option in audio/flac. Unfortunately, the configure script does not handle --without-ogg, so unchecking the OGG option with ogg installed will lead to a hidden dependency, but at least people who don't have+want ogg installed will be able to avoid it. >How-To-Repeat: >Fix: - Add ogg in OPTIONS - Move LIB_DEPENDS to OGG_LIB_DEPENDS - Move ogg CONFIGURE_ARGS to OGG_CONFIGURE_ON CONFIGURE_ON is used because the configure script does not like --without-ogg="${LOCALBASE}", that CONFIGURE_WITH would generate with OGG=off. Build log: https://redports.org/buildarchive/20131110075236-89415/ Patch attached with submission follows: diff -ruN flac-org/Makefile flac/Makefile --- flac-org/Makefile 2013-09-24 17:39:26.000000000 -0400 +++ flac/Makefile 2013-11-10 02:35:50.000000000 -0500 @@ -10,27 +10,27 @@ MAINTAINER= naddy@FreeBSD.org COMMENT= Free lossless audio codec -LIB_DEPENDS= libogg.so:${PORTSDIR}/audio/libogg - USES= pathfix pkgconfig USE_AUTOTOOLS= libtool USE_LDCONFIG= yes USE_XZ= yes GNU_CONFIGURE= yes CONFIGURE_ARGS= --enable-sse \ - --with-ogg="${LOCALBASE}" \ --disable-silent-rules \ --disable-thorough-tests \ --disable-xmms-plugin -OPTIONS_DEFINE= DOCS ICONV -OPTIONS_DEFAULT=ICONV +OPTIONS_DEFINE= DOCS ICONV OGG +OPTIONS_DEFAULT=ICONV OGG ICONV_USES= iconv ICONV_CPPFLAGS= -I${ICONV_PREFIX}/include ICONV_LDFLAGS= -L${ICONV_PREFIX}/lib ICONV_CONFIGURE_OFF= am_cv_func_iconv=no +OGG_CONFIGURE_ON= --with-ogg="${LOCALBASE}" +OGG_LIB_DEPENDS= libogg.so:${PORTSDIR}/audio/libogg + .include .if ${ARCH} == "i386" >Release-Note: >Audit-Trail: >Unformatted: