From owner-dev-commits-src-all@freebsd.org Wed Jun 30 18:20:29 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8B901649771 for ; Wed, 30 Jun 2021 18:20:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GFV585P5Xz3MKF for ; Wed, 30 Jun 2021 18:20:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82a.google.com with SMTP id w13so2202688qtc.0 for ; Wed, 30 Jun 2021 11:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VRAyvI2zrUF0l9CQ72dPQjQ8fxz7QaJlEDtDxyGEQ9E=; b=szoRE6GIwL+DJkuRsHb30I+oraQlDTIYhLdsW9EUNYvWv8rUsy6sEYSfolKd1U6xQw XnfaQcLzMejAmJwX99BDKk0kGQ6gkFRReQWzus6DQlO5nB/W5jBABFc1nz4A3I6AtEdc Mw8FiqNh5qkn/cJL7b8adhr+MPoyCg4dOc5ZJfele21qPkCTmU224oCIFrdWfyx5h1iY umwoMHcnuTpYVINtxF/zCFkkD8Yp+od/Gz8FJX6yzSupgq5zxCeQnDaWJF1FcJYVg8QP HByAI1iM9whMWmYm/j39lkEhEU+fwcXB9x8gK0ActqvRcPyK9Sn0gkcYJweEbadcVgGa 5i/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VRAyvI2zrUF0l9CQ72dPQjQ8fxz7QaJlEDtDxyGEQ9E=; b=Naqc/DTzwdd3YfOTxnym3HsOy2lRTkueTGft42LB/Lj09ZZabyyUiQ9CpOwGrQvp31 4s+iIAcMZjaG18DIwGJLwz9Z6yHBjh2dNTGA7KzhThZRusa70cayEOgQh/SKIhZDC5Mf xIJkiql+BMREzMAbHUn137vFW+NEVG5Jgm7SlrEh9dyoFwzGe7fRLdD+2R3iN8yTAsth KvqcIB8vi8yE2t782qCgb58MUwPoUalL1i1t/61SJ7uW2FUhqssinVtJpGyp8Kaq6F9s HCfkSDpm1UYTBv0pxik9lBFAf1rtZOnyc7QGllAE8FmTLf98W+GoPlGH6CzwKV2tSakc zzsg== X-Gm-Message-State: AOAM532PMM2q6+u+ABY+6T9H3daFsJx9wcPjiSMm0YNuhLb0w3fs5k9c 8m+jn+QHeACpuH5mo+cFgczSPeB+nAjIIlFQsK5rsQ== X-Google-Smtp-Source: ABdhPJwlYfYskREbtAyT9Hh9aMH2LOT7HlN5TqXClzjHSP7b34ZsKJcrerqksnYzFiirlKhmFL/gTvfmKI66NPYo3p4= X-Received: by 2002:a05:622a:164d:: with SMTP id y13mr33005191qtj.244.1625077227725; Wed, 30 Jun 2021 11:20:27 -0700 (PDT) MIME-Version: 1.0 References: <202106301720.15UHKkUQ079377@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 30 Jun 2021 12:20:17 -0600 Message-ID: Subject: Re: git: 3f197b101f71 - main - release: Remove C-like string comparison operator To: Alexey Dokuchaev Cc: Warner Losh , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4GFV585P5Xz3MKF X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=szoRE6GI; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::82a) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.95 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-0.95)[-0.945]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::82a:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::82a:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::82a:from]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[dev-commits-src-all]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jun 2021 18:20:29 -0000 On Wed, Jun 30, 2021 at 11:59 AM Alexey Dokuchaev wrote: > On Wed, Jun 30, 2021 at 05:20:46PM +0000, Warner Losh wrote: > > commit 3f197b101f71ee4f4949c53bf330f61b43749ce9 > > > > release: Remove C-like string comparison operator > > > > Per [(1), i.e. test(1), the string comparison operator should be `=`, > > not `==` in sh(1) scripts. > > > > No functional change. FreeBSD's test accepts `==` as an alias for `=` > > for compatibility with gnu test's `==` extension. > > Nice, thanks, but why didn't you remove those needless quotes around > static stings, e.g. "GPT" -> GPT? > Sure, that could also be done. However, I'll leave it to the re@ team. It works either way, and I've seen both styles in the tree (and outside it as well). Warner