From owner-svn-src-all@FreeBSD.ORG Wed Nov 11 13:49:23 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B8FA1065670; Wed, 11 Nov 2009 13:49:23 +0000 (UTC) (envelope-from trasz@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 4B0F38FC08; Wed, 11 Nov 2009 13:49:23 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id nABDnMLd096359; Wed, 11 Nov 2009 13:49:22 GMT (envelope-from trasz@svn.freebsd.org) Received: (from trasz@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id nABDnMQh096358; Wed, 11 Nov 2009 13:49:22 GMT (envelope-from trasz@svn.freebsd.org) Message-Id: <200911111349.nABDnMQh096358@svn.freebsd.org> From: Edward Tomasz Napierala Date: Wed, 11 Nov 2009 13:49:22 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r199183 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2009 13:49:23 -0000 Author: trasz Date: Wed Nov 11 13:49:22 2009 New Revision: 199183 URL: http://svn.freebsd.org/changeset/base/199183 Log: Revert r198873. Having different VAPPEND semantics for VOP_ACCESS(9) and VOP_ACCESSX(9) is not a good idea. Modified: head/sys/kern/vfs_default.c Modified: head/sys/kern/vfs_default.c ============================================================================== --- head/sys/kern/vfs_default.c Wed Nov 11 12:55:58 2009 (r199182) +++ head/sys/kern/vfs_default.c Wed Nov 11 13:49:22 2009 (r199183) @@ -353,14 +353,6 @@ vop_stdaccessx(struct vop_accessx_args * if (accmode == 0) return (0); - /* - * Many VOP_APPEND implementations don't expect VAPPEND without VWRITE - * being set, e.g. they check whether the filesystem is read-only only - * when VWRITE is set. Make sure we don't confuse them. - */ - if (accmode & VAPPEND) - accmode |= VWRITE; - return (VOP_ACCESS(ap->a_vp, accmode, ap->a_cred, ap->a_td)); }