From owner-svn-src-head@freebsd.org Tue Jan 17 23:21:21 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B39E9CB55F1; Tue, 17 Jan 2017 23:21:21 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 50E4C17C6; Tue, 17 Jan 2017 23:21:20 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wm0-f54.google.com with SMTP id c85so221928646wmi.1; Tue, 17 Jan 2017 15:21:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=DOGI3p3DSfSm6K3d5h9gx6IJmAjShAu/m1BUFfJLIoE=; b=XaMNXtY+dMcFc5el/soAho+UPNwUNVoBkACZ6lkhGo9suSRQwPZxVny7aq+te9+YBA fJR5OtV74/yVu9aUL/Uukn6Qdfpaav1jFsNWANHfr2uxT7O7lZF/vv3ocnh/XB/d6OOR 4bkY9Py4EhlH8iQnljSC7ZzFCo23EGcj7sFq67y2/XC+2cSPwxEnr8+2SHnLbNoTBMfK xKDXdlMk/yb7xmS1LDvMtfhRRROU14otWb9R/jJ4cnyKgncuMVLbDSVxiVAZt3rV8RkY W+e6PaFDMgYTXYngsqX9VEPrGY5VohyWn1j2ukuY3safVGcjlH6sW6P8ingEwhFXYgXz biNA== X-Gm-Message-State: AIkVDXIlHjPRtOzolHW2W2PLTvcdpoJItdI75EkH5elc9Y8uNDXRyA576FIjb/yxXinukg== X-Received: by 10.223.134.151 with SMTP id 23mr159011wrx.0.1484695279036; Tue, 17 Jan 2017 15:21:19 -0800 (PST) Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com. [74.125.82.44]) by smtp.gmail.com with ESMTPSA id 204sm40555516wmj.7.2017.01.17.15.21.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jan 2017 15:21:18 -0800 (PST) Received: by mail-wm0-f44.google.com with SMTP id r144so247567754wme.1; Tue, 17 Jan 2017 15:21:18 -0800 (PST) X-Received: by 10.223.174.183 with SMTP id y52mr144595wrc.112.1484695278766; Tue, 17 Jan 2017 15:21:18 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.194.29.72 with HTTP; Tue, 17 Jan 2017 15:21:18 -0800 (PST) In-Reply-To: References: <201701161746.v0GHkcPX071529@repo.freebsd.org> <20170117065231.GW2611@FreeBSD.org> <20170117212713.GZ2611@FreeBSD.org> From: Conrad Meyer Date: Tue, 17 Jan 2017 15:21:18 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg To: Maxim Sobolev Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 23:21:21 -0000 Ian's potential objection has been met by Ben Kaduk and Eric van Gyzen's responses. It seems like an enum is just fine. And I agree with Gleb that it is preferable. Conrad On Tue, Jan 17, 2017 at 1:34 PM, Maxim Sobolev wrote: > Well as other pointed out there are some concerns with using enums from C++ > and ABI prospective. So it looks to me that there is no general consensus on > that direction. > > -Max > > On Tue, Jan 17, 2017 at 1:27 PM, Gleb Smirnoff wrote: >> >> On Tue, Jan 17, 2017 at 08:40:50AM -0800, Maxim Sobolev wrote: >> M> That being said, is there any other socket option value in there >> M> implemented as enum? I don't see anything obvious, so that I am curious >> if >> M> it would stick out as an odd one in there. What do you think? >> >> Simply because 30 years ago the language didn't allow that, and later >> additions mimiced the older sockopts. We need to break this loop :) >> >> -- >> Totus tuus, Glebius. >> >