From owner-svn-src-all@freebsd.org Wed Nov 4 14:17:18 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 663C845DDB6; Wed, 4 Nov 2020 14:17:18 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CR7yP1MsBz3YWc; Wed, 4 Nov 2020 14:17:16 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-ej1-f54.google.com with SMTP id o21so22942861ejb.3; Wed, 04 Nov 2020 06:17:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=fMoy1WW6PF86lkZPEO+J2EDbWaLovqCewxgZgXJZRfw=; b=bgElPdwe4Xx+5j91c/8pWOEy9+CZ3oTdLMUpGe9DESByqTlLa/6rhNzYqHNf8is1bi bCdry0sra9ZdT0dK0j7wqDNeo3xkQx8OAxsCnaeP8qRNN/cd50VNFjdwhDltxp6PAyq7 +B44759DBq3vcYjBS7/bhyIcsW1Jjxz1Cv8dZedyL8jAOrhStA+Q8u71f+gukMH6ip7q 6ZE/nMbKWQXx16WxqXMoCFIRmmCQTJbIf2Q6g86UOfPDM4Sp3+PW7OQqICNz8nXeysMv N9u9GEn/U9gKOlugb1+dTWHFafBjUC1jj+ObwxxnL+ZgBQFXgKiJpcC/Fo1fDwO/BsSS dRaA== X-Gm-Message-State: AOAM533btBXde+Ej87jFUcP3SbC2WTrqbhsATP4klajsf+kon5LsmZW+ noZRThNJ6UtsErXauXjPCU6iDAnsWxgPBQ== X-Google-Smtp-Source: ABdhPJyFvk4dJngRCpmtkO99a2C/bixs7xltKl/tHwrmjMOjmo2zxr/A5OJMEAxF/eFZC5ARP9rsIA== X-Received: by 2002:a17:906:6d0c:: with SMTP id m12mr25277785ejr.498.1604499434973; Wed, 04 Nov 2020 06:17:14 -0800 (PST) Received: from ?IPv6:2a02:8109:98c0:1bc0:5e5f:67ff:fef4:ffd8? ([2a02:8109:98c0:1bc0:5e5f:67ff:fef4:ffd8]) by smtp.gmail.com with ESMTPSA id z18sm1065492ejf.41.2020.11.04.06.17.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Nov 2020 06:17:14 -0800 (PST) Subject: Re: svn commit: r367321 - head/sys/amd64/linux To: Kristof Provost , Gordon Bergling Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202011041038.0A4AcPNn082013@repo.freebsd.org> <20201104104515.GA83813@lion.0xfce3.net> From: Mateusz Piotrowski <0mp@FreeBSD.org> Message-ID: Date: Wed, 4 Nov 2020 15:17:17 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 4CR7yP1MsBz3YWc X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mpp302@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=mpp302@gmail.com X-Spamd-Result: default: False [-2.35 / 15.00]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[209.85.218.54:from]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-1.03)[-1.028]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-1.01)[-1.009]; NEURAL_HAM_SHORT(-0.31)[-0.314]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.218.54:from]; FORGED_SENDER(0.30)[0mp@FreeBSD.org,mpp302@gmail.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[0mp@FreeBSD.org,mpp302@gmail.com]; MAILMAN_DEST(0.00)[svn-src-head,svn-src-all] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2020 14:17:18 -0000 Hi! On 11/4/20 1:09 PM, Kristof Provost wrote: > On 4 Nov 2020, at 11:45, Gordon Bergling wrote: >> Shouldn't such a commit be approved by someone? >> > The committer’s guide seems clear that doc committers may fix comments: > > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/committer.types.html > >> doc committers may commit documentation changes to src files, such as man pages, READMEs, fortune >> databases, calendar files, and comment fixes without approval from a src committer, subject to >> the normal care and tending of commits. > > Arguably minor spelling fixes are not worth confusing the blame output for, but this seems well > within the established rules. +1 BTW, I've another similar patch pending (this time for pmcstat) if some src committer could take a look: https://reviews.freebsd.org/D26082. > >> And why you just abandoned the differential [1]? >> > Probably because it timed out. The review had been pending since August. > Arguably the differential link should have been included as well, but it’s hardly important in > this case. I don’t think we have explicit policies about this. We probably should. I forgot to link to the review on Phabricator. I didn't follow up with an email as it didn't seem important enough to show up in everyone's mailbox. Cheers! Mateusz