From owner-cvs-src@FreeBSD.ORG  Wed Mar 26 23:45:06 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7449A37B404; Wed, 26 Mar 2003 23:45:06 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 399CD43F93; Wed, 26 Mar 2003 23:45:05 -0800 (PST)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.8/8.12.8) with ESMTP id h2R7j3b6030006;
	Thu, 27 Mar 2003 08:45:04 +0100 (CET)
	(envelope-from phk@phk.freebsd.dk)
To: Tor Egge <tegge@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 26 Mar 2003 15:40:42 PST."
             <200303262340.h2QNegJg065498@repoman.freebsd.org> 
Date: Thu, 27 Mar 2003 08:45:03 +0100
Message-ID: <30005.1048751103@critter.freebsd.dk>
X-Spam-Status: No, hits=-14.8 required=5.0
	tests=AWL,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,
	      REPLY_WITH_QUOTES
	version=2.50
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp)
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/conf NOTES files options src/sys/kern
	vfs_bio.c src/sys/ufs/ffs ffs_rawread.c ffs_vnops.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Mar 2003 07:45:08 -0000

In message <200303262340.h2QNegJg065498@repoman.freebsd.org>, Tor Egge writes:
>tegge       2003/03/26 15:40:42 PST
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/conf             NOTES files options 
>    sys/kern             vfs_bio.c 
>    sys/ufs/ffs          ffs_vnops.c 
>  Added files:
>    sys/ufs/ffs          ffs_rawread.c 
>  Log:
>  Add support for reading directly from file to userland buffer when the
>  O_DIRECT descriptor status flag is set and both offset and length is a
>  multiple of the physical media sector size.

I am neither impressed nor thrilled by this.

We already have pretty firm plans for converting struct bio from a
"mapped KVM" to a a "virtual/physical scatter/gather" thing in the
6-current, and that is the correct way to solve this problem.

If this is a crucial feature for 5-stable, I would far rather add
we push ahead with that plan, than see more pbuf based hacks in the
kernel.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.