From owner-freebsd-current@freebsd.org Wed Jan 18 18:30:55 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7DA7CB55CE for ; Wed, 18 Jan 2017 18:30:55 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B5EA91190 for ; Wed, 18 Jan 2017 18:30:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 2C7E510A7B9; Wed, 18 Jan 2017 13:30:52 -0500 (EST) From: John Baldwin To: Jakob Alvermark Cc: freebsd-current@freebsd.org, Shawn Webb Subject: Re: r311568 makes freerdp very slow Date: Wed, 18 Jan 2017 10:29:44 -0800 Message-ID: <3516356.ILt4XdM4E4@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: <59599.193.12.143.142.1484657191.squirrel@webmail.alvermark.net> References: <57236.193.12.143.142.1484240708.squirrel@webmail.alvermark.net> <64999.85.229.93.187.1484344018.squirrel@webmail.alvermark.net> <59599.193.12.143.142.1484657191.squirrel@webmail.alvermark.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Wed, 18 Jan 2017 13:30:52 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 18:30:56 -0000 On Tuesday, January 17, 2017 01:46:31 PM Jakob Alvermark wrote: > On Fri, January 13, 2017 22:46, Jakob Alvermark wrote: > > On Fri, January 13, 2017 19:44, John Baldwin wrote: > > > >> On Friday, January 13, 2017 09:58:01 AM Jakob Alvermark wrote: > >> > >> > >>> On Thu, January 12, 2017 19:26, John Baldwin wrote: > >>> > >>> > >>>> On Thursday, January 12, 2017 12:42:11 PM Shawn Webb wrote: > >>>> > >>>> > >>>> > >>>>> On Thu, Jan 12, 2017 at 06:05:08PM +0100, Jakob Alvermark wrote: > >>>>> > >>>>> > >>>>> > >>>>>> Hi, > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> r311568 Set MORETOCOME for AIO write requests on a socket. > >>>>>> > >>>>>> After this commit freerdp is very slow. > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> Before the password prompt would appear immediately when > >>>>>> connecting to a server. Now it takes 5-10 seconds. After > >>>>>> entering the password, another 5-10 seconds until I am > >>>>>> connected. Once connected, there is a considerable lag. > >>>>>> > >>>>>> > >>>>>> What could be the problem? > >>>>>> > >>>>>> > >>>>>> > >>>>> > >>>>> I don't know what the problem is, but I am seeing the same > >>>>> symptom. > >>>>> > >>>>> > >>>> > >>>> Can you get a ktrace of the freerdp process during this? The > >>>> commit should only be setting MORETOCOME if multiple aio_write > >>>> requests are queued to the same socket (so that TCP can batch them > >>>> into a single packet). However, it should not affect an application > >>>> just calling aio_write() on a socket once. > >>>> > >>>> -- > >>>> John Baldwin > >>>> > >>>> > >>> > >>> Hi John, > >>> > >>> > >>> > >>> I got the ktrace, what do I do with it? > >>> > >>> > >> > >> kdump will generate a text representation, perhaps using 'kdump -s' to > >> not include dumps of raw I/O data. If you can put the output of kdump > >> at a URL I can fetch from then I can look at it. > >> > > > > OK, here it is: http://filebin.ca/38mkuLau9Yqu/ktrace.out.xfreerdp.txt > > > > > > Thanks, > > > > > > Jakob > > Hi, > > Did you get any chance to look at this? I have not yet, but can you please try the fix in r312387? -- John Baldwin