From owner-svn-src-head@freebsd.org Wed Jan 10 17:20:19 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76AF9E691E8 for ; Wed, 10 Jan 2018 17:20:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x233.google.com (mail-it0-x233.google.com [IPv6:2607:f8b0:4001:c0b::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 374867F959 for ; Wed, 10 Jan 2018 17:20:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x233.google.com with SMTP id p139so266579itb.1 for ; Wed, 10 Jan 2018 09:20:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Ro03w/bqno8X+23SQeloL4vwPWyl0URLsEIMVhLDumE=; b=SlEyT49iSFZPChNC74dIfMldKcsVz9+pB3tx++TpppC3tyyFOYW29nDHK9d1yVpJ61 8CDk4ZTskgbKbf1f0dkNpIjmQlhW5szNjfd4fytszvVCTSHpGOx88sj+ZoKkIPVy2JXp JqqwyWzzay6aJPLDk7rCSKjTJPu4/n1rjTnwEhI8d8uW6zXCZPpKyxsKLTzcagvUb7bx LiaO2lFRbM6F18G2rrbQuCv9nku4K6yTeOLE1fQu5y1VGLnya8qSz4qN3X/7UzOnXSvy FoWZSlDLmV8efmpgpikFyx9PFq9AX9lR8vUeVy7YF2TvbYMCDC76G5TgqzpeyEQRQRmA c21Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Ro03w/bqno8X+23SQeloL4vwPWyl0URLsEIMVhLDumE=; b=TfEf9kYLanKqYVOkgeXR/LUMJqeW8nnK0AI0Mt1wNoe/vOpKdwK9d98MKnwPiXebIv CVySOYVXxyAFxLeIMnCuw5XV49ACHGZLqhPOZQwQjwg9FJIpOpdRdx7haVxhbvADIUb8 yaUsakE50tKBU2EFDw86BAcrvIoF8D/klGLlZU/1CR9fAfhKv25u6MyCgNAw0tbO8MII FCah5Kp1V+dUvtdVXikNQxKJHshxS0fdDxnIa8CmKLp/+CIrTH7cCPCnKWjd1fzFJETW z01xRRCaJT/27lAUgfPnJsxWDUyTZnOb6frvwKX6KzrCwItK2li734mYLY+Jp7iNiTIL UXPQ== X-Gm-Message-State: AKGB3mL5mEgGGOc7GRYWta0tOAINfCPabdT3KFatIHBVoq5dGZMECpVQ tPHXV5hhepIsU8Ow7lOw2VRlRIIFG1XeBeqZ6bJ8Mw== X-Google-Smtp-Source: ACJfBosBg5tqtdCZb487OTKas90l+0/Ft8JdZdbxQLkrFrwzfCos7SiFmisyxGb4I8llqeqAVc0gU4M2nN7mDCISHZg= X-Received: by 10.36.74.200 with SMTP id k191mr20706107itb.69.1515604818300; Wed, 10 Jan 2018 09:20:18 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.160.217 with HTTP; Wed, 10 Jan 2018 09:20:17 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <20180110171444.GA85022@FreeBSD.org> References: <201801101459.w0AExJWM055025@repo.freebsd.org> <201801101631.w0AGVAEV032087@pdx.rh.CN85.dnsmgr.net> <20180110165821.GA69465@FreeBSD.org> <20180110171444.GA85022@FreeBSD.org> From: Warner Losh Date: Wed, 10 Jan 2018 10:20:17 -0700 X-Google-Sender-Auth: x4k1i6h9bIC6F_07sEh7qmRo_ls Message-ID: Subject: Re: svn commit: r327767 - in head/sys: conf i386/bios i386/conf i386/isa To: Alexey Dokuchaev Cc: "Rodney W. Grimes" , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Warner Losh Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 17:20:19 -0000 On Wed, Jan 10, 2018 at 10:14 AM, Alexey Dokuchaev wrote: > On Wed, Jan 10, 2018 at 10:01:41AM -0700, Warner Losh wrote: > > On Wed, Jan 10, 2018 at 9:58 AM, Alexey Dokuchaev > wrote: > > > On Wed, Jan 10, 2018 at 09:48:05AM -0700, Warner Losh wrote: > > > > On Wed, Jan 10, 2018 at 9:31 AM, Rodney W. Grimes wrote: > > > > > > New Revision: 327767 > > > > > > URL: https://svnweb.freebsd.org/changeset/base/327767 > > > > > > > > > > > > Log: > > > > > > Retire pmtimer driver. Move time fixing into apm driver. Move > > > > > > Iwasaki-san's copyright over. Remove FIXME code that couldn't > > > possibly > > > > > > work. Call tc_settime() with our estimate of the delta we've > been > > > > > > alseep (the one we print) to adjust the time. Not sure what to > do > > > > > > about callouts, so keep the small #ifdef in place there. > > > > > > > > > > > > Differential Revision: https://reviews.freebsd.org/D13823 > > > > > > > > > > RELNOTES: ? > > > > > Reason I ask is this effects custom kernel config file(s) > > > > > > > > Don't know. We don't normally document every kernel config file > changes > > > > that's required. > > > > > > Well, `pmtimer' is a bit special. It is required in the kernel config > in > > > order to preserve time counting during suspend (not sure about amd64, > but > > > at least on i386, "device pmtimer" is required to be in kernel config > for > > > timekeeping while sleeping). > > > > It's only required for APM. ACPI it's a nop. > > > > And it didn't (until I believe that I fixed it) even adjust the time for > > APM. On APM it just prints how long the sleep was. > > Not sure of now, but at least back in 2013 pmtimer was required on my i386 > ACPI-ish laptop (it is still required now, but I just don't run -CURRENT): > > https://lists.freebsd.org/pipermail/svn-src-all/2013-May/069020.html It's been a nop in ACPI only on -current. Prior to making it a nop on current ACPI set the time, it was a nop for amd64. Warner