From owner-p4-projects@FreeBSD.ORG Wed Jun 23 20:20:48 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 656D11065672; Wed, 23 Jun 2010 20:20:48 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29872106564A; Wed, 23 Jun 2010 20:20:48 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id F04A18FC14; Wed, 23 Jun 2010 20:20:47 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 911AD46B2C; Wed, 23 Jun 2010 16:20:47 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id AA6938A03C; Wed, 23 Jun 2010 16:20:46 -0400 (EDT) From: John Baldwin To: Alexandre Fiveg Date: Wed, 23 Jun 2010 13:19:49 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201006171446.o5HEkRSP022515@repoman.freebsd.org> In-Reply-To: <201006171446.o5HEkRSP022515@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201006231319.49258.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Wed, 23 Jun 2010 16:20:46 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00, DATE_IN_PAST_03_06 autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Perforce Change Reviews Subject: Re: PERFORCE change 179713 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2010 20:20:48 -0000 On Thursday 17 June 2010 10:46:27 am Alexandre Fiveg wrote: > http://p4web.freebsd.org/@@179713?ac=10 > > Change 179713 by afiveg@cottonmouth on 2010/06/17 14:46:03 > > Begin with new design for ringmap: > 1. The new structure with pointers to hardware dependent functions: > "struct ringmap_functions" (/net/ringmap.h) > 2. Pointer to this structure placed in ringmap structure. > 3. In the ringmap_attach function look for pci Id of network controller, > and then, depending on controllers type, initialize the functions pointers: > (ringmap.c: set_ringmap_funcs()) I think 3) is the wrong way to go about it. Can't you have the NIC driver attach a ringmap and supply the function pointers to the NIC-specific functionality instead? You really don't want to have two separate lists of device IDs. The ringmap list will invariably become stale. -- John Baldwin