From owner-freebsd-toolchain@freebsd.org Fri Sep 21 20:37:30 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1070710A3816; Fri, 21 Sep 2018 20:37:30 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9AA5B8F56B; Fri, 21 Sep 2018 20:37:29 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it1-x143.google.com with SMTP id u13-v6so3481844iti.1; Fri, 21 Sep 2018 13:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ewg150DxSHkNuGgy6/mzZJjwSSCVShTZKD1CAs99/TI=; b=bAmq00249kEt86VYUrrFcH5r8sq2JPFhXYL17PB3NCcI8sxvqGjaownHd8AG75oUqd Xy9LoS9UbNuYqAd3AkJnq08mVuJgaG9cK9YJftyagnln6x+RWQWzeZoaZ+qPAMFLRu+F nFBalNGuwKdGD/UljSymAu8aUp/9vjFDWXm4l0rJchtu0HMc3UqRD7yjukcG7CXk37mY 41PBjUDlGc/UnCzP1Fla8gawSClVsUsa/EkfZbxGAc77JhvhfB1OLdx3cZp469oCCELi vQcHgsDd0WVvIcdill9O2QzKG0YH28ZSXsve6+zGknyHlk52ZFkj+NTA1wYXCMaU3Pig ihqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ewg150DxSHkNuGgy6/mzZJjwSSCVShTZKD1CAs99/TI=; b=eJQrmbov1if8b8YhMjhvPsXS47/L09V5C9JpQvaVXM7zPcTRZOhy0AFrrodlna6h67 mebUAQKZYJe1wlBu31H4lFjvEp0GhHKw04/unGs4okj/XHFQxOWmZ+C7ZD3CVglSr9/u B6LsB1qbe5mmIHO1pWV0bsSWm5guiPxtxbFmDE08PMFgOGlyopz/8BCDsdfYIPQUy+TP ggaXqvXjZKl97eb4MWBZV9KTN95q3GCKg32TU6YzXE2BwZg0XsJA3Bnz7LuTJF1aWM4v gSygrTVrnEFzx2Av+D+5SuaiqadxSHKyr8s6nBHG3DwUWlKRQxHAu2FV8IxrSb1btta9 o99Q== X-Gm-Message-State: APzg51DOApaOFflhniWvIPy3kbymRUrfeYUs9nxOOlD+kCLAj9aljDgq LtrX6htyvOmvaYHq4iHmSkZLNhp2qmDwSqt4JK0n5Amo X-Google-Smtp-Source: ANB0VdaCMXd5zW62yxm8iML20NgnGLUuu0d7452IMwirbEQ7LdnINcuoC3MTszm6UToOZqv6zu4GZwFgiJ7gGZq9nbA= X-Received: by 2002:a02:9a10:: with SMTP id b16-v6mr431395jal.4.1537562248760; Fri, 21 Sep 2018 13:37:28 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 2002:a6b:404:0:0:0:0:0 with HTTP; Fri, 21 Sep 2018 13:37:08 -0700 (PDT) In-Reply-To: <20180921193139.GB5120@raichu> References: <2E7136DD-9C25-44C1-8C9A-310C2D1D7189@yahoo.com> <20180921193139.GB5120@raichu> From: Ed Maste Date: Fri, 21 Sep 2018 16:37:08 -0400 X-Google-Sender-Auth: BgY9uEC6snM6MwmAD8fttdZCDms Message-ID: Subject: Re: building head -r338675 with devel/amd64-gcc: /usr/local/x86_64-unknown-freebsd12.0/bin/ld: warning: -z ifunc-noplt ignored To: Mark Johnston Cc: Mark Millard , FreeBSD Toolchain , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 20:37:30 -0000 On 21 September 2018 at 15:31, Mark Johnston wrote: > > Perhaps the following? It's not quite right since it'll still use > -zifunc-noplt with an external LLVM toolchain, but I can't seem to > figure out how to define a linker feature for only non-cross toolchains. > In any case, we're going to upstream the option soon. I wouldn't worry too much about out-of-tree since it will be upstream soon as you say, otherwise looks good. > +.if ${MACHINE_CPUARCH} == "amd64" || ${MACHINE_CPUARCH} == "i386" > +.if defined(LINKER_FEATURES) && ${LINKER_FEATURES:Mifunc} == "" > .error amd64/i386 kernel requires linker ifunc support > .endif > +.if defined(LINKER_FEATURES) && ${LINKER_FEATURES:Mifunc-noplt} != "" Maybe roll && defined(LINKER_FEATURES) into the outer .if?