From owner-freebsd-fs@freebsd.org Mon Aug 3 13:49:01 2015 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0300E9B2FF3 for ; Mon, 3 Aug 2015 13:49:01 +0000 (UTC) (envelope-from wjw@digiware.nl) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id DCADA1C30 for ; Mon, 3 Aug 2015 13:49:00 +0000 (UTC) (envelope-from wjw@digiware.nl) Received: by mailman.ysv.freebsd.org (Postfix) id D94229B2FF2; Mon, 3 Aug 2015 13:49:00 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D8D529B2FF1 for ; Mon, 3 Aug 2015 13:49:00 +0000 (UTC) (envelope-from wjw@digiware.nl) Received: from smtp.digiware.nl (smtp.digiware.nl [31.223.170.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9B87D1C2F; Mon, 3 Aug 2015 13:49:00 +0000 (UTC) (envelope-from wjw@digiware.nl) Received: from rack1.digiware.nl (unknown [127.0.0.1]) by smtp.digiware.nl (Postfix) with ESMTP id 02DE6153466; Mon, 3 Aug 2015 15:48:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at digiware.nl Received: from smtp.digiware.nl ([127.0.0.1]) by rack1.digiware.nl (rack1.digiware.nl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QdkD0jl-sliS; Mon, 3 Aug 2015 15:48:48 +0200 (CEST) Received: from [192.168.101.176] (vpn.ecoracks.nl [31.223.170.173]) by smtp.digiware.nl (Postfix) with ESMTPA id 615C9153431; Mon, 3 Aug 2015 15:48:48 +0200 (CEST) Subject: Re: Multiple entries in ZFS "sharenfs" property? To: lev@FreeBSD.org References: <130767529.20150801150343@serebryakov.spb.ru> <55BDF5D2.3090306@digiware.nl> <1941826477.20150802210808@serebryakov.spb.ru> <55BE83FA.1060208@digiware.nl> <55BF5932.2090107@FreeBSD.org> <55BF5D16.9060705@digiware.nl> <55BF61B5.1040404@FreeBSD.org> Cc: fs@freebsd.org From: Willem Jan Withagen Message-ID: <55BF7140.3090804@digiware.nl> Date: Mon, 3 Aug 2015 15:48:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55BF61B5.1040404@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2015 13:49:01 -0000 On 3-8-2015 14:42, Lev Serebryakov wrote: > On 03.08.2015 15:22, Willem Jan Withagen wrote: > >> 'mmmm PR URL is missing, I looked but did not find anything. > It was in beginning of thread: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=147881 Yup, found it. >> Just send you some code this morning.... Don't you have commit >> bits??? So you could checkin a fix if you wanted? > I'm almost sure, that such commit to ZFS from me will be reverted > ASAP :) there are some objections against such change in PR147881. Which is sad.... The only objections from bugs.. (although not unimportant) were from Martin Matuska. And they are more about the incompatibility between the other versions for ZFS running on Solaris-variants... He then closes with: Have you considered using /etc/exports. Which is of course a dead giveaway, with that as argument why even bother to export sharenfs.... Just block access to it, and have people always use /etc/exports...., rip out the fsshare stuff, and there are no more code incompatibilities. And as far as I can tell fsshare.c is already a FreeBSDism? So the mismatch with other OSes is there and will stay there. It is not like you'd want to merge your pools to a different OS and automagically upon import get NFS exports for that pool? As Sysadmin I'd rather not have that happen. The code in 147881 is quite a lot of lines, but does the trick. The patch I made is a lot less and no comments allowed, does about the same. The status of the report is still "In progress". So nobody saw fit to close it. And thus it is still waiting for a fix?? --WjW