From owner-svn-src-all@freebsd.org Mon Jun 1 21:43:35 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F2E452F372A; Mon, 1 Jun 2020 21:43:35 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 49bTFL6CfHz3bYx; Mon, 1 Jun 2020 21:43:34 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id fsDSju30yng7KfsDTjafiu; Mon, 01 Jun 2020 15:43:33 -0600 X-Authority-Analysis: v=2.3 cv=ecemg4MH c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=nTHF0DUjJn0A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=J-IugnFFISbjiFo_lpUA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id A6B27434; Mon, 1 Jun 2020 14:43:28 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id 051LhSOS073955; Mon, 1 Jun 2020 14:43:28 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id 051LhS8D073952; Mon, 1 Jun 2020 14:43:28 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202006012143.051LhS8D073952@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Michael Tuexen cc: "Alexander V. Chernikov" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r361706 - in head/sys: net net/route netinet netinet6 In-reply-to: <6FE2C649-2D81-4C9C-B821-D8226B6BB95C@fh-muenster.de> References: <202006012049.051KnhxX060695@repo.freebsd.org> <6FE2C649-2D81-4C9C-B821-D8226B6BB95C@fh-muenster.de> Comments: In-reply-to Michael Tuexen message dated "Mon, 01 Jun 2020 23:28:37 +0200." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 01 Jun 2020 14:43:28 -0700 X-CMAE-Envelope: MS4wfMQ72Uyu7AfAtHSClUAryTUlyjy17yZg4YDNjDaG+VMPukaE6DgOOohQwcMPV+PWh33VzYNVk5yguAc4co/s5eSslq8kjBrQZ3UDQgHlxBDMCtRLRSi/ 3LEnsJG9bBzdRrsocQ6DS6oZFN2HpM6nJWMa4n+HUHueB4NAdFuz/BZkWBrbRvMgW6qKbrNTahygFIC+5PDBrB02A8vGe7faNglJa62VkMj6Su7c/1BWwvjm KLXsgROq4d5CmL/yx7t7ivxnh7hak/0D9oFae+FxAcbEg9Y8FAuftMRGS+MdSG0J4uF1Q1toG8WoQLJAtw5kLcUc01jpU3d8vta1elBaVlM= X-Rspamd-Queue-Id: 49bTFL6CfHz3bYx X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.134.13) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-0.11 / 15.00]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-0.28)[-0.278]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; ARC_NA(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RECEIVED_SPAMHAUS_PBL(0.00)[70.67.125.17:received]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.42)[-0.423]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; NEURAL_HAM_MEDIUM(-0.71)[-0.713]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[64.59.134.13:from] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2020 21:43:36 -0000 In message <6FE2C649-2D81-4C9C-B821-D8226B6BB95C@fh-muenster.de>, Michael Tuexe n writes: > > --Apple-Mail=_30A6D176-B5FA-4F13-A949-3CE33C73C3B8 > Content-Transfer-Encoding: quoted-printable > Content-Type: text/plain; > charset=us-ascii > > > On 1. Jun 2020, at 22:49, Alexander V. Chernikov = > wrote: > >=20 > > Author: melifaro > > Date: Mon Jun 1 20:49:42 2020 > > New Revision: 361706 > > URL: https://svnweb.freebsd.org/changeset/base/361706 > >=20 > > Log: > > * Add rib__route() functions to manipulate the = > routing table. > >=20 > > The main driver for the change is the need to improve notification = > mechanism. > > Currently callers guess the operation data based on the rtentry = > structure > > returned in case of successful operation result. There are two = > problems with > > this appoach. First is that it doesn't provide enough information = > for the > > upcoming multipath changes, where rtentry refers to a new nexthop = > group, > > and there is no way of guessing which paths were added during the = > change. > > Second is that some rtentry fields can change during notification = > and > > protecting from it by requiring customers to unlock rtentry is not = > desired. > >=20 > > Additionally, as the consumers such as rtsock do know which operation = > they > > request in advance, making explicit add/change/del versions of the = > functions > > makes sense, especially given the functions don't share a lot of = > code. > >=20 > > With that in mind, introduce rib_cmd_info notification structure and > > rib__route() functions, with mandatory rib_cmd_info = > pointer. > > It will be used in upcoming generalized notifications. > >=20 > > * Move definitions of the new functions and some other = > functions/structures > > used for the routing table manipulation to a separate header file, > > net/route/route_ctl.h. net/route.h is a frequently used file = > included in > > ~140 places in kernel, and 90% of the users don't need these = > definitions. > >=20 > > Reviewed by: ae > > Differential Revision: https://reviews.freebsd.org/D25067 > >=20 > > Modified: > > head/sys/net/if_llatbl.c > > head/sys/net/route.c > > head/sys/net/route.h > > head/sys/net/route/nhop_ctl.c > > head/sys/net/route/route_ctl.c > > head/sys/net/route/route_ddb.c > > head/sys/net/route/route_helpers.c > > head/sys/net/route/route_temporal.c > > head/sys/net/route/route_var.h > > head/sys/netinet/in_rmx.c > > head/sys/netinet/ip_icmp.c > > head/sys/netinet6/icmp6.c > > head/sys/netinet6/in6_rmx.c > > head/sys/netinet6/nd6_rtr.c > >=20 > > Modified: head/sys/net/if_llatbl.c > > = > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D > > --- head/sys/net/if_llatbl.c Mon Jun 1 20:40:40 2020 = > (r361705) > > +++ head/sys/net/if_llatbl.c Mon Jun 1 20:49:42 2020 = > (r361706) > > @@ -58,6 +58,7 @@ __FBSDID("$FreeBSD$"); > > #include > > #include > > #include > > +#include > Where is this file coming from? That was in r361704 and reverted in r361705, but should have been in this commit too. > > Best regards > Michael -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.