From owner-freebsd-bugs Sat Apr 13 5: 0:13 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 82FC237B416 for ; Sat, 13 Apr 2002 05:00:06 -0700 (PDT) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g3DC06X60395; Sat, 13 Apr 2002 05:00:06 -0700 (PDT) (envelope-from gnats) Received: from bunrab.catwhisker.org (adsl-63-193-123-122.dsl.snfc21.pacbell.net [63.193.123.122]) by hub.freebsd.org (Postfix) with ESMTP id EBE8137B400 for ; Sat, 13 Apr 2002 04:54:16 -0700 (PDT) Received: from d144.catwhisker.org (d144.catwhisker.org [172.16.8.144]) by bunrab.catwhisker.org (8.12.2/8.12.2) with ESMTP id g3DBsGZG068493 for ; Sat, 13 Apr 2002 04:54:16 -0700 (PDT) (envelope-from david@mailhost.catwhisker.org) Received: from d144.catwhisker.org (localhost [127.0.0.1]) by d144.catwhisker.org (8.12.2/8.12.2) with ESMTP id g3DBsF7o068758 for ; Sat, 13 Apr 2002 04:54:15 -0700 (PDT) (envelope-from david@d144.catwhisker.org) Received: (from david@localhost) by d144.catwhisker.org (8.12.2/8.12.2/Submit) id g3DBsDtx068757; Sat, 13 Apr 2002 04:54:13 -0700 (PDT) Message-Id: <200204131154.g3DBsDtx068757@d144.catwhisker.org> Date: Sat, 13 Apr 2002 04:54:13 -0700 (PDT) From: David Wolfskill Reply-To: David Wolfskill To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/37036: Make "periodic" output show positive "end-of-report" info Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 37036 >Category: bin >Synopsis: Make "periodic" output show positive "end-of-report" info >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Apr 13 05:00:06 PDT 2002 >Closed-Date: >Last-Modified: >Originator: David Wolfskill >Release: FreeBSD 4.5-STABLE i386 >Organization: Wolfskill & Dowling residence >Environment: System: FreeBSD d144.catwhisker.org 4.5-STABLE FreeBSD 4.5-STABLE #139: Fri Apr 12 06:07:26 PDT 2002 root@d144.catwhisker.org:/common/S1/obj/usr/src/sys/LAPTOP_30W i386 Aplies equally well to -CURRENT. >Description: The output from "periodic" is a collection of outputs from a variety of individual scripts. As such, if the output were to be truncated for some reason, the recipient of the report could well fail to notice this. While this could well be considered the responsibility of the recipient, there is a small thing we could do to make the recipient's life a little easier: just add a line to indicate that "this is the end." >How-To-Repeat: Check the output of "periodic". For example, here's the tail end of the "security" output for my build machine: freebeast.catwhisker.org login failures: freebeast.catwhisker.org refused connections: My laptop, however, has received tghe below patch; here is its corresponding output: d144.catwhisker.org login failures: d144.catwhisker.org refused connections: End of output from security Note that I'm not trying to do anything fancy here -- no crypto hashes, or anything like that. Just a simple visual confirmation that the end of the report didn't drop off into the aether. >Fix: The following works for me. Please consider it as a suggestion -- season to taste: cvs diff: Diffing usr.sbin/periodic Index: usr.sbin/periodic/periodic.sh =================================================================== RCS file: /cvs/freebsd/src/usr.sbin/periodic/periodic.sh,v retrieving revision 1.9.2.7 diff -u -r1.9.2.7 periodic.sh --- usr.sbin/periodic/periodic.sh 26 Nov 2000 06:06:18 -0000 1.9.2.7 +++ usr.sbin/periodic/periodic.sh 11 Apr 2002 22:53:57 -0000 @@ -97,6 +97,9 @@ then [ $processed = 1 ] && plural= || plural=s echo "No output from the $processed file$plural processed" + else + echo "" + echo "End of output from ${arg}" fi } | eval $pipe done >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message