From owner-freebsd-current@FreeBSD.ORG  Fri Nov  5 19:00:24 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 830B81065673
	for <freebsd-current@freebsd.org>; Fri,  5 Nov 2010 19:00:24 +0000 (UTC)
	(envelope-from markjdb@gmail.com)
Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com
	[209.85.160.182])
	by mx1.freebsd.org (Postfix) with ESMTP id DF1C08FC2D
	for <freebsd-current@freebsd.org>; Fri,  5 Nov 2010 19:00:17 +0000 (UTC)
Received: by gya6 with SMTP id 6so2469080gya.13
	for <freebsd-current@freebsd.org>; Fri, 05 Nov 2010 12:00:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:date:from:to:cc:subject
	:message-id:references:mime-version:content-type:content-disposition
	:in-reply-to:user-agent;
	bh=zEleHvxLGo4t+sINmznqpNVtfJtbubO0gDHcL5cTMBs=;
	b=siriz+Wy0B6wsQ9WuND5AQH5wnZPXA9VVKzvJaMYuqQdGssMP9uHFOXDqCKA2VH3lm
	+2KABv/pd4Eru2JrzItlRErbCaCpH9Krysn1feFbB0J5xwA2lLQH9fjEPgCQHCwQuq2Z
	FkzCFm2FRybi4CbOuSBVpqmSA93OoLB7Ah8Ak=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=date:from:to:cc:subject:message-id:references:mime-version
	:content-type:content-disposition:in-reply-to:user-agent;
	b=jmL7hw4FzwHcr7nR1jQQ15uUELJSyL1EY6awAqeIUlMZpCaDOGfw0KGweXfq67IHai
	BUi262wr/94tlHn8oG4y/2fiWgzuNy7CK2J1jUg6fc618uc8Ne7mv35KAevNKKqZJfEr
	zz03eB4HFAxp/2Pm0iW/DOUnmvvcrLWlpD1is=
Received: by 10.100.58.9 with SMTP id g9mr51419ana.107.1288983616937;
	Fri, 05 Nov 2010 12:00:16 -0700 (PDT)
Received: from mark-laptop-bsd.mark-home (Mail1.sandvine.com [64.7.137.162])
	by mx.google.com with ESMTPS id b25sm1778624anb.3.2010.11.05.12.00.15
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Fri, 05 Nov 2010 12:00:16 -0700 (PDT)
Date: Fri, 5 Nov 2010 14:59:58 -0400
From: Mark Johnston <markjdb@gmail.com>
To: Nick Hibma <nick@van-laarhoven.org>
Message-ID: <20101105185958.GC1437@mark-laptop-bsd.mark-home>
References: <20101024231119.GA2123@mark-laptop-bsd.mark-home>
	<20101024231642.GB2123@mark-laptop-bsd.mark-home>
	<A72115A0-00E4-4FDB-974C-E06D31116794@van-laarhoven.org>
	<20101105152009.GB1437@mark-laptop-bsd.mark-home>
	<08D6E625-5BE9-4121-A0D8-8B5BDA20A813@van-laarhoven.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <08D6E625-5BE9-4121-A0D8-8B5BDA20A813@van-laarhoven.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: freebsd-current@freebsd.org
Subject: Re: [Patch] libfetch - closing the cached FTP connection
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Nov 2010 19:00:24 -0000

On Fri, Nov 05, 2010 at 07:27:43PM +0100, Nick Hibma wrote:
> > I think using fcntl is nicer than having a "close the cached connection"
> > function, but I don't think I can get around this problem without
> > changing something in libfetch.
> 
> I think libfetch should set the Close-On-Exec flag. It's wrong to have these files propagate to children.
> 
> Nick_______________________________________________

Oh I see, I thought you were talking about changing pkg_add alone. I'll
post an alternative patch to the PR I opened (bin/151866).

Thanks,
-Mark