From nobody Wed Feb 5 17:49:50 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yp76Q1Tvnz5n63V; Wed, 05 Feb 2025 17:49:50 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yp76Q0yjwz3Gpm; Wed, 05 Feb 2025 17:49:50 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738777790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wscPDZv4JX7h8lGsiPRUs5pS319qyZno+x1u3XPhxso=; b=lTqBYDGq72R5IBAhBs7X/1KJ/P5e+wMSaOjk05/BSXzT5EfyorulXZoJmZc19GM6U+1pwn JAXr/ERw8vDYB6c3rntd6PByFWW6yGbnxMEEpCsj1aGOA6uMopbhuB0z0f3ew5b6gZFEWy jP4e60YoZaD4ycMYejjCKJBPF95SLIf75sCr6Wq95jN3fjwAM8uYGZDQK0r8XChwONPPRV Y/9s5/HazQZAaO2wWWOt430f7J+lIPwV5B/N+fSDysDb+6+PJ5swL+BND2BmLMaGH+a8mh jqS5uZbNCXNx4OUcs0KDox/5T9CS/E5e2jtwLCtuoqq/naR5DFYtBg4aRWvoZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738777790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wscPDZv4JX7h8lGsiPRUs5pS319qyZno+x1u3XPhxso=; b=cs83LA7tUdqOw7H96U/O2nGDzLxdcdWMDPoTTsVRyw/9KUekINS73/B5D9KgrCaUbL+Si8 T07ARHQcWos9icV9w0hEt3UB5yEES1Trg9mXuNqDwWfhLG7whIkGtH9IiwiZ1YHMQeqOIw qBW4z6F1MtZOmQFzYJVLtt1mdkND+FaUfM+N01aPxQOpRPDTCL5PargTIxgz/ROFUDCt9N 96kDxp4esCGbsEApwdjduVu+6xKmNdgDKISpKkuYgQHFseG2i/VqCdyODu/42Bjtfj4mlp SlsGc5Ukh+w/dub5JmJUxCHQVX6I+GPENxyFHWDuGtE4IDMgiAzhxugioyVl9w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738777790; a=rsa-sha256; cv=none; b=j7hkrXsSheotUniVZ5NUTVBO26IMSkT3uvwrgtQTW7I2uymTgYrQPPQDuIFi0VWD+V/VE/ QF5cOk+Kn/L5QHnfVzpViyCMg+kbJqFedbVCTHo/mK7cNTc9Fhlj2sbg0ErGgyMA+n8rKq UPNRVdBwgL/JKUNQKPK+KmJT3Of7pBoW9qPICgA635OLIm+xY/znQYd4Cal/7uBa41gQDF DCIkZPn1M+uhEQUlkJvjoUF5jGQSQgZtpAfW4F1AljLAqLoJ7NNLRH/GGoC5SPdzHA/yI6 Psa+8UQkUAZa4og4wgPD9wv6V/irbsH8bu0eJKkjcyg0liv/hcl26g8tDW5Y5w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: by freefall.freebsd.org (Postfix, from userid 1033) id 15D08D4F6; Wed, 05 Feb 2025 17:49:50 +0000 (UTC) Date: Wed, 5 Feb 2025 17:49:50 +0000 From: Alexey Dokuchaev To: Ryan Steinmetz Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4ca613c4414b - main - irc/eggdrop: Fix build, bump PORTREVISION Message-ID: References: <202501291814.50TIEUIr089656@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 04, 2025 at 04:10:50PM +0000, Ryan Steinmetz wrote: > On (01/30/25 05:57), Alexey Dokuchaev wrote: > > On Wed, Jan 29, 2025 at 06:14:30PM +0000, Ryan Steinmetz wrote: > > > commit 4ca613c4414b2dfaa9de5336b6da5a74aa73f5d4 > > > > > > irc/eggdrop: Fix build, bump PORTREVISION > > > > > > PR: 283584 > > > ... > > > post-patch: > > > - @${REINPLACE_CMD} -e 's|tcl.h|tcl${TCL_VER}/tcl.h|g' ${WRKSRC}/src/mod/python.mod/pycmds.c > > > + @${SED} -i '' -e '25d' ${WRKSRC}/src/mod/python.mod/pycmds.c > > > > There are several issues with this commit. It doesn't explain what > > was the problem and how removing 25th line fixes it. Wasn't there > > a better anchor than the line number? Also, why use ${SED} -i '' > > instead of canonical ${REINPLACE_CMD}? Last, if it's a *build* fix, > > why bump port revision? > > The submitter was following the exiting patterns (use of SED) in the port. > > I've updated SED->REINPLACE_CMD and moved the line 25 deletion to a patch > as I expect it will be replaced whenever upstream merges the open PR to > address this. Yeah, I've seen the commit, thank you. Not that I really insisted on the patch (see below), it was more of a general observation that we (all) should review/rethink submitted work better prior to commit, and try to write more elaborate commit logs because not everyone reading them would be on the same page with committer or maintainer and have immediate access to the PR or source tarball. > From the PR: > > In file included from .././python.mod/python.c:46: > .././python.mod/pycmds.c:25:10: fatal error: 'tcl8.6/tcl.h' file not found > 25 | #include > | ^~~~~~~~~~~~~~ > 1 error generated. It wasn't hard to figure, but this requires actually running "make patch". E.g. /^#include /d is more descriptive than 25d and less likely do delete something unintended if line numbers change; but oh well, the patch would also do. ./danfe