From owner-cvs-all Tue Feb 5 18:58:35 2002 Delivered-To: cvs-all@freebsd.org Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by hub.freebsd.org (Postfix) with ESMTP id 2424937B400 for ; Tue, 5 Feb 2002 18:58:13 -0800 (PST) Received: (qmail 6439 invoked from network); 6 Feb 2002 02:58:10 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([65.91.155.143]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 6 Feb 2002 02:58:10 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020206061908.G260-100000@gamplex.bde.org> Date: Tue, 05 Feb 2002 21:58:01 -0500 (EST) From: John Baldwin To: Bruce Evans Subject: RE: cvs commit: src/sys/i386/i386 db_interface.c Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Bruce Evans Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 05-Feb-02 Bruce Evans wrote: > On Tue, 5 Feb 2002, John Baldwin wrote: > >> On 30-Jan-02 Bruce Evans wrote: >> > bde 2002/01/30 10:23:32 PST >> > >> > Modified files: >> > sys/i386/i386 db_interface.c >> > Log: >> > Backed out the last vestiges of rev.1.51. Don't enter a critical >> > region in Debugger(), since rev.1.468 of machdep.c does this better. >> > Other cosmetic backouts. >> >> Err, have you tested this? In my tests locally this still doesn't work >> properly which is why I haven't committed it. :( > > PS: perhaps you are thinking of the flag in Debugger(). That is > fundamentally broken too. It just protects against multiple entries to > the debugger when the first entry is via the console debugger key. Try > the following: > - enter ddb using the key > - hit the key again. No problem since the flag is set. > - single step until the flag is unset > - hit the key again. This causes a fine mess. > The same thing mess happens when you enter ddb via a breakpoint and hit the > key, except the console driver is not reentered then (unless the breakpoint > is in the console driver). Hmm, the problem I was having is that interrupts were still firing while I was in ddb. I could tell because new KTR entries due to clock interrutps kept showing up. > Bruce -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message