From owner-svn-src-all@freebsd.org Mon Dec 28 07:46:50 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E067BA54857; Mon, 28 Dec 2015 07:46:50 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail110.syd.optusnet.com.au (mail110.syd.optusnet.com.au [211.29.132.97]) by mx1.freebsd.org (Postfix) with ESMTP id ACEA71D0F; Mon, 28 Dec 2015 07:46:50 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c211-30-166-197.carlnfd1.nsw.optusnet.com.au (c211-30-166-197.carlnfd1.nsw.optusnet.com.au [211.30.166.197]) by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id 85DA3781CD9; Mon, 28 Dec 2015 18:21:42 +1100 (AEDT) Date: Mon, 28 Dec 2015 18:21:41 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Marcelo Araujo cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292817 - head/usr.bin/systat In-Reply-To: <201512280207.tBS27vds094913@repo.freebsd.org> Message-ID: <20151228170552.V2375@besplex.bde.org> References: <201512280207.tBS27vds094913@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=R4L+YolX c=1 sm=1 tr=0 a=KA6XNC2GZCFrdESI5ZmdjQ==:117 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8 a=kj9zAlcOel0A:10 a=6I5d2MoRAAAA:8 a=7DT2vUWpYU7gVe86gssA:9 a=CjuIK1q_8ugA:10 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2015 07:46:51 -0000 On Mon, 28 Dec 2015, Marcelo Araujo wrote: > Log: > Add on systat -vm the ability to display the physical and kernel memory > percent usage. > > PR: bin/203917 > Submitted by: ota > Approved by: bapt (mentor) > Differential Revision: https://reviews.freebsd.org/D4281 This has lots of style bugs in both the output and the source code. There was negative space for expansion, but some space is used to squeeze memory- related variables in between the general stats line and the memory lines. I think they would fit in the general stats line and not look quites as bad there. This line now uses 67 columns and only needs about 50 of these. Style bugs start with not updating the comment about STATROW. It still says that that this (really the STAT window) uses 1 row and 67 columns, but it now uses 2 row. This use is an abuse. It would be clearer to put the new memory statistics in a new window. They don't really fit in tje MEM window either, and putting them there would change all the existing line numbers there. Some other statistics are squeezed into out of the way places and not printed if the terminal is not large enough. nbuf is one of these. Displaying it is not very useful since (like the variables in this commit and unlike almost all the other variables in the display), it is constant. It is also less useful than the variables in this commit. So it is put on line 24 of 0-24 and not displayed unless the terminal has > 25 lines since the last line is reserved for input. I recently noticed that the interrupt lines are misformatted by letting them run into the interactive i/o line (probably also outside the window where they are not displayed of course) if there are many of them. Then if you do input, it makes a mess by erasing the last displayed interrupt line, but not completely. The line is first erased completely, but later the count is refreshed but the description is not. Switching to another display and back gives the same mess, with the description displayed for an instant on switching back before it is erased by info on the i/o line. Bruce