Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Apr 2011 07:14:22 +0000 (UTC)
From:      Ruslan Ermilov <ru@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r220614 - head/sys/dev/ipmi
Message-ID:  <201104140714.p3E7EM31024428@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ru
Date: Thu Apr 14 07:14:22 2011
New Revision: 220614
URL: http://svn.freebsd.org/changeset/base/220614

Log:
  Fixed firmware revision decoding:
  - the major is 7-bit binary encoded
  - the minor is BCD encoded
  
  PR:		kern/151586
  MFC after:	3 days

Modified:
  head/sys/dev/ipmi/ipmi.c

Modified: head/sys/dev/ipmi/ipmi.c
==============================================================================
--- head/sys/dev/ipmi/ipmi.c	Thu Apr 14 00:07:08 2011	(r220613)
+++ head/sys/dev/ipmi/ipmi.c	Thu Apr 14 07:14:22 2011	(r220614)
@@ -713,10 +713,10 @@ ipmi_startup(void *arg)
 		return;
 	}
 
-	device_printf(dev, "IPMI device rev. %d, firmware rev. %d.%d, "
+	device_printf(dev, "IPMI device rev. %d, firmware rev. %d.%d%d, "
 	    "version %d.%d\n",
 	     req->ir_reply[1] & 0x0f,
-	     req->ir_reply[2] & 0x0f, req->ir_reply[4],
+	     req->ir_reply[2] & 0x7f, req->ir_reply[3] >> 4, req->ir_reply[3] & 0x0f,
 	     req->ir_reply[4] & 0x0f, req->ir_reply[4] >> 4);
 
 	ipmi_free_request(req);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201104140714.p3E7EM31024428>