From owner-freebsd-usb@FreeBSD.ORG  Thu May  5 22:21:27 2005
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5562016A4CE
	for <usb@freebsd.org>; Thu,  5 May 2005 22:21:27 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3D24043D7E
	for <usb@freebsd.org>; Thu,  5 May 2005 22:21:26 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.13.3/8.13.1) with ESMTP id j45MKfpE094524;
	Thu, 5 May 2005 16:20:41 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Thu, 05 May 2005 16:20:41 -0600 (MDT)
Message-Id: <20050505.162041.116001724.imp@bsdimp.com>
To: julian@elischer.org
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <20050505.161351.59748132.imp@bsdimp.com>
References: <20050505.160055.78800132.imp@bsdimp.com>
	<427A98ED.1000704@elischer.org>
	<20050505.161351.59748132.imp@bsdimp.com>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: usb@freebsd.org
cc: usbcrash@oldach.net
Subject: Re: recent USB MFCs cause panics
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 May 2005 22:21:27 -0000

From: Warner Losh <imp@bsdimp.com>
Subject: Re: recent USB MFCs cause panics
Date: Thu, 05 May 2005 16:13:51 -0600 (MDT)

> > Is there a reason tio not just remove the method entry?
> > will it default to a good default?   (i.e. not an error default?)
> > if not then I guess just stubbibg the method would work..
> 
> Maybe you should look at the current code rather than taking the
> scatter gun approach to hoping that there's a magic bullet.

Sorry for the short reply, but the current code has:

USB_DECLARE_DRIVER_INIT(uhub,
	DEVMETHOD(bus_child_pnpinfo_str, uhub_child_pnpinfo_str),
	DEVMETHOD(bus_child_location_str, uhub_child_location_str),
	DEVMETHOD(bus_driver_added, bus_generic_driver_added),
	DEVMETHOD(device_suspend, bus_generic_suspend),
	DEVMETHOD(device_resume, bus_generic_resume),
	DEVMETHOD(device_shutdown, bus_generic_shutdown)
	);

But there's more than just removing the entry in the table to making
it work.

Warner