From owner-cvs-all Thu Jun 24 0:42:22 1999 Delivered-To: cvs-all@freebsd.org Received: from allegro.lemis.com (allegro.lemis.com [192.109.197.134]) by hub.freebsd.org (Postfix) with ESMTP id 4722214EE7; Thu, 24 Jun 1999 00:42:14 -0700 (PDT) (envelope-from grog@freebie.lemis.com) Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by allegro.lemis.com (8.9.1/8.9.0) with ESMTP id RAA25382; Thu, 24 Jun 1999 17:12:13 +0930 (CST) Received: (from grog@localhost) by freebie.lemis.com (8.9.3/8.9.0) id RAA00713; Thu, 24 Jun 1999 17:12:11 +0930 (CST) Date: Thu, 24 Jun 1999 17:12:11 +0930 From: Greg Lehey To: Dag-Erling Smorgrav Cc: Brian Feldman , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Names in commit message (was: cvs commit: src/sys/i386/i386 identcpu.c src/sys/i386/isa clock.c) Message-ID: <19990624171211.C427@freebie.lemis.com> References: <199906240348.UAA02888@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.4i In-Reply-To: ; from Dag-Erling Smorgrav on Thu, Jun 24, 1999 at 09:16:11AM +0200 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Thursday, 24 June 1999 at 9:16:11 +0200, Dag-Erling Smorgrav wrote: > Brian Feldman writes: >> Reviewed by: msmith >> Obtained from: unfurl & msmith > > Incorrect use of 'Obtained from'. The 'Obtained from' field is for > when you merge in patches from {Net,Open}BSD. You should have used > 'Submitted by' and specified Bill and Mike's complete e-mail addresses > (and real names if known): The usage I've seen has been to include just the mail ID if it's a committer, and the complete name and mail ID otherwise. When did you last see a Nitpicked-by: Bruce Evans ? Greg -- See complete headers for address, home page and phone numbers finger grog@lemis.com for PGP public key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message