Date: Thu, 24 Jun 1999 17:12:11 +0930 From: Greg Lehey <grog@lemis.com> To: Dag-Erling Smorgrav <des@flood.ping.uio.no> Cc: Brian Feldman <green@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Names in commit message (was: cvs commit: src/sys/i386/i386 identcpu.c src/sys/i386/isa clock.c) Message-ID: <19990624171211.C427@freebie.lemis.com> In-Reply-To: <xzphfnyf4qs.fsf@flood.ping.uio.no>; from Dag-Erling Smorgrav on Thu, Jun 24, 1999 at 09:16:11AM %2B0200 References: <199906240348.UAA02888@freefall.freebsd.org> <xzphfnyf4qs.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, 24 June 1999 at 9:16:11 +0200, Dag-Erling Smorgrav wrote:
> Brian Feldman <green@FreeBSD.org> writes:
>> Reviewed by: msmith
>> Obtained from: unfurl & msmith
>
> Incorrect use of 'Obtained from'. The 'Obtained from' field is for
> when you merge in patches from {Net,Open}BSD. You should have used
> 'Submitted by' and specified Bill and Mike's complete e-mail addresses
> (and real names if known):
The usage I've seen has been to include just the mail ID if it's a
committer, and the complete name and mail ID otherwise. When did you
last see a
Nitpicked-by: Bruce Evans <bde@FreeBSD.org>
?
Greg
--
See complete headers for address, home page and phone numbers
finger grog@lemis.com for PGP public key
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990624171211.C427>