From owner-svn-src-head@freebsd.org Wed Jun 28 19:25:56 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 886C2DA85D6; Wed, 28 Jun 2017 19:25:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 53F35844E3; Wed, 28 Jun 2017 19:25:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x242.google.com with SMTP id z6so10149834pfk.3; Wed, 28 Jun 2017 12:25:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=NIGMiBUAfXG0FlmHlk3HqGYCJ6k0b4rIInLDs7XTUWY=; b=HupFriJUrVTG40ZpBm+SByDpDXCi+R3tHupUnDdT5zuh7evCo5mkJM2HkiQjPxuZqo qh2WItxDanCucsJWKBfD8hfb9Fwrmde1BsjtmYs8ltaDUZHdFshbLgFg1zjxpBCt+urD ViKjzNto4e3l5q2XqMjxMb9r3jZF/gNhTxMIOABHsMARnFhQnzIyNiWGbpK+70YLwRgF wZRLVU/eun72JLjHbmDn/0lFzo4fbS4LhRirdSKGQWqw2/9mbgSCjnQIHzHE1r1wL35s 6IWa3sp8oZptUppq5IKKOL95xTE/vevxQvwGGZpB7Y9ucjhMLKdD7gkF85tnW0mpeYRB rTzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=NIGMiBUAfXG0FlmHlk3HqGYCJ6k0b4rIInLDs7XTUWY=; b=YdypKIJ1xvu+30VSmqSE6ma7IJ9kawL853EYzqeyPhN9Rn4pizqzx0WQC9c1Ibs5tY 6ItDJH8GteEIhZpfVEAAfRrqzHsy5+Vdbk35fcVZaVGzYWp7JmeN7tIm51p6GrP0/uX0 M3n9lw2NDLbgk2dFqJUyfgVI7EayK8OKWy+GT7zyGwX548CeBTbIJcunjuPtnPMfGRUx YUskJPgm+Yooyzd66tWmWI7adDtiV1PZUm0yEMI6OGZ7fRzLrZM6r02XFOT43eLotTPS NxdqiFmR7PmWJdTeG61lBAuI2ESwwFx3dElYgutzY/ghask9Ofjoxam1GEsxNEhuhlTx HTeg== X-Gm-Message-State: AKS2vOzVQevUHDRfbIn/3bAy9lcsrxm12pVXDyAA/mvQFZ1kU+n4vrDG zHFcjMqN6hnj0hrNcQg= X-Received: by 10.84.128.195 with SMTP id a61mr13762699pla.130.1498677955645; Wed, 28 Jun 2017 12:25:55 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id x25sm7676426pfi.58.2017.06.28.12.25.54 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Jun 2017 12:25:54 -0700 (PDT) Subject: Re: svn commit: r320454 - head/share/zoneinfo Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_08D0994E-C5E0-4E84-ACF1-C103E9A01AF3"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201706281905.v5SJ55Zb062532@repo.freebsd.org> Date: Wed, 28 Jun 2017 12:25:53 -0700 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <3305BCF7-0978-4152-B3AD-309FD891B59D@gmail.com> References: <201706281905.v5SJ55Zb062532@repo.freebsd.org> To: Cy Schubert X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jun 2017 19:25:56 -0000 --Apple-Mail=_08D0994E-C5E0-4E84-ACF1-C103E9A01AF3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jun 28, 2017, at 12:05, Cy Schubert wrote: >=20 > Author: cy > Date: Wed Jun 28 19:05:04 2017 > New Revision: 320454 > URL: https://svnweb.freebsd.org/changeset/base/320454 >=20 > Log: > Allow parallel installworld (-j N) and poudriere installworld > (poudriere jail -c and poudriere jail -u) to proceed. >=20 > Reviewed by: trasz@ > Tested by: trasz@, cy@ > MFC after: 1 month > X-MFC-with: r320362 >=20 > Modified: > head/share/zoneinfo/Makefile >=20 > Modified: head/share/zoneinfo/Makefile > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/share/zoneinfo/Makefile Wed Jun 28 17:32:09 2017 = (r320453) > +++ head/share/zoneinfo/Makefile Wed Jun 28 19:05:04 2017 = (r320454) > @@ -94,7 +94,7 @@ install-zoneinfo: > .for f in ${TZS} > ${INSTALL} ${TAG_ARGS} \ > -o ${BINOWN} -g ${BINGRP} -m ${NOBINMODE} \ > - ${TZBUILDDIR:C,^${.OBJDIR}/,,}/${f} = ${DESTDIR}/usr/share/zoneinfo/${f} > + ${TZBUILDDIR}/${f} ${DESTDIR}/usr/share/zoneinfo/${f} > .endfor > ${INSTALL} ${TAG_ARGS} -o ${BINOWN} -g ${BINGRP} -m ${NOBINMODE} = \ > ${CONTRIBDIR}/zone.tab ${DESTDIR}/usr/share/zoneinfo/ Thank you for getting this in! In general, I would argue that for/.for loops in Make targets = are bad like this I think that individual targets could in fact be = created, and driven as a dependency of a top-level target, to avoid this = issue and keep bdrewery=E2=80=99s intended change in r320362, e.g. = something like, install-zones: .PHONY .for f in ${TZS} install-zones: ${DESTDIR}/usr/share/zoneinfo/${f} ${DESTDIR}/usr/share/zoneinfo/${f}: ${f} ${INSTALL} ... .endfor I=E2=80=99m not incredibly sure based on this commit alone why = this Makefile isn=E2=80=99t using FILES though=E2=80=A6 I=E2=80=99ll = look at it closer when I have a spare minute. Thanks, -Ngie --Apple-Mail=_08D0994E-C5E0-4E84-ACF1-C103E9A01AF3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZVALBAAoJEPWDqSZpMIYVgcYP/3R5QvAZnRidzyPdfHFGOekX uL2esI0enXJUnlgQsQLSWi5aG6nDONAi3EanKI0OgJ2iKpRdKX5OFs+2rahcm6uD MaQyvbn/5+lL25g9O1V5/P5Eoa32kMkvYxHkxaz3YPJzkLto1I2R2J9Hj3g6jVU2 OrmPz71vU0X1G2QthXOzf63w+wbUF8YlmSrzZ2+ZgMeCKzfUdLuWrGejgY9ETHEz BbhLXQ2uvYqjJ4Ij00ojvMZCx5xaeFWpU5AR9dluwyaWp90U4Ey+5sPKdw2K/x5D +KNib3mgs79/K3vHSfr8ahyFUijxZN3uTmeGaBcOhQRr8ngI51ZmzWq83A0cGy/P yWg8mNeJ8CNhNoHE2bGyEYJxyBbAkykOqH5IidtgUMg+uO7JSNi15gZ5C77xmRFx GM191qQEQDpo7e6XcwM8/vUsqcTv1Az8MHnViuiDSC9D2ZZVgj/ZWG7jNt4HZquw 7PlwSGu1DXdlyhCPCa9dplOv3yuVbLJE9FOajfwstket7Jq8AwKLghaZlL+V7M8T X6UJEIUUVitmhzKd9cZqNopbZSsWX2dCx5mkxEY96+q/6gCnido0Tvk6TBfGyQGt nl+6+X0BHZk33bsVQL1jYWEQhJBYa/txlO8ZoORiu6cpNou1feaXhh3y7S++Q2Dq +oqopbUVDfjeK5B4/KTP =/DIH -----END PGP SIGNATURE----- --Apple-Mail=_08D0994E-C5E0-4E84-ACF1-C103E9A01AF3--