From owner-cvs-all Thu Jun 15 22: 3:22 2000 Delivered-To: cvs-all@freebsd.org Received: from redfish.go2net.com (redfish.go2net.com [207.178.55.5]) by hub.freebsd.org (Postfix) with ESMTP id 7927C37BCEA; Thu, 15 Jun 2000 22:03:17 -0700 (PDT) (envelope-from marcs@go2net.com) Received: from marcs (helo=localhost) by redfish.go2net.com with local-esmtp (Exim 2.11 #1) id 132oHP-0005ft-00; Thu, 15 Jun 2000 22:02:55 -0700 Date: Thu, 15 Jun 2000 22:02:54 -0700 (PDT) From: Marc Slemko X-Sender: marcs@redfish To: John-Mark Gurney Cc: Alfred Perlstein , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern uipc_socket.c uipc_socket2.c src/sys/sys socket.h In-Reply-To: <20000615161246.37298@hydrogen.funkthat.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, 15 Jun 2000, John-Mark Gurney wrote: > Alfred Perlstein scribbled this message on Jun 15: > > until the incoming connection has either data waiting or what looks like a > > HTTP request header already in the socketbuffer. This ought to reduce > > the context switch time and overhead for processing requests. > > if this code stays (which I hope it either gets removed, or made into > a kld module), it should be updated to check for ALL the various > possible http requests... (such as HEAD, etc.) Actually, no, it should not be a generalized to be fully able to grok all possible requests. While I agree that this sort of hardcoded gunk isn't necessarily appropriate where it is (or even useful for performance, outside of very constrained benchmark situations), if you are going to add special code to the kernel, then you want to keep a small fast path in the kernel that covers the common case. You can cover 90% of the cases with 10% of the code, then everything else just punts down the way things normally work. More speed for the common case, less complexity, and a lot less chance of bugs. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message