From owner-freebsd-ports@FreeBSD.ORG Tue Mar 12 15:58:35 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D8EEB16C for ; Tue, 12 Mar 2013 15:58:35 +0000 (UTC) (envelope-from decke@bluelife.at) Received: from mail-oa0-f53.google.com (mail-oa0-f53.google.com [209.85.219.53]) by mx1.freebsd.org (Postfix) with ESMTP id 8CEA5801 for ; Tue, 12 Mar 2013 15:58:35 +0000 (UTC) Received: by mail-oa0-f53.google.com with SMTP id m1so5809587oag.40 for ; Tue, 12 Mar 2013 08:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bluelife.at; s=google; h=mime-version:x-received:sender:x-originating-ip:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type; bh=VLIUTphJWHIVosOn5G3FVJUdkc4r0WoNhl/9fTtZPNA=; b=Apct7kkac6YX0FiTkEH8mUzeAPJjfFcc6APz5SzGKSs+XFnDCgFYCOg1rAGuis6dFa klvbWSMcDCd2CKGz6h7/cGZ6ykeGUl2ywy6cZt8+k+JQJX2eplV11QOOiG87ktjpsk26 C23EHAN9r1Tn16/uf7oV21FaUhIkLG9a9jwa8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:sender:x-originating-ip:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:x-gm-message-state; bh=VLIUTphJWHIVosOn5G3FVJUdkc4r0WoNhl/9fTtZPNA=; b=iXDRqJUMnQTLtGcZKPdRQ8D3PgckgAwRczOWaEb2tk5BkEgBjmZk0K5Hi2Ybvtjgi/ Op9vmjaBq5194nKrW1sR76fQu+eNj37qAZ1NkDk3PGdn6rjsJtFhefkqLWFSRoKvq1Aj psv79BZL8ywmGzeBZw0ycxeixa0x/aOrfqydUhhoPCxwGO7NGf2f8brtIUde+mddCD9f 9JWo1+61wqwtXBgNNhqqWfGuM7wtn34Y8IekLez7H8JbEyhtlhhmIekfAmjKd2TORhik QQRSZBlYqgH046isDY3+/qsyV93zydNwtsKMg0GRT+MCZ5CjU4er0iSCyMr2zl084lhq G0DQ== MIME-Version: 1.0 X-Received: by 10.182.139.37 with SMTP id qv5mr12273357obb.92.1363103914623; Tue, 12 Mar 2013 08:58:34 -0700 (PDT) Sender: decke@bluelife.at Received: by 10.76.154.199 with HTTP; Tue, 12 Mar 2013 08:58:34 -0700 (PDT) X-Originating-IP: [80.123.233.199] In-Reply-To: <20130312151751.GJ3794@kib.kiev.ua> References: <513DA3AD.1000603@gmail.com> <1363089703.20974.6.camel@z6000.lenzicasa> <20130312151751.GJ3794@kib.kiev.ua> Date: Tue, 12 Mar 2013 16:58:34 +0100 X-Google-Sender-Auth: TcAQIatTXIszca843iGwNzoH350 Message-ID: Subject: Re: VirtualBox patch From: =?ISO-8859-1?Q?Bernhard_Fr=F6hlich?= To: Konstantin Belousov Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnv2cxyJkjFFwqzDhbqVII7nylyz2VNsrSXDa4rVwKyQq8omu60KNqrR0Nob7TnBwm9rW/X Cc: Ferenc Balku , Sergio de Almeida Lenzi , ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2013 15:58:35 -0000 On Tue, Mar 12, 2013 at 4:17 PM, Konstantin Belousov wrote: > On Tue, Mar 12, 2013 at 09:01:43AM -0300, Sergio de Almeida Lenzi wrote: >> Em Seg, 2013-03-11 ??s 10:28 +0100, Ferenc Balku escreveu: >> >> > Hi Sergio! >> > >> > Awfully sorry to disturb You, but I have found this link via Google >> > http://lists.freebsd.org/pipermail/freebsd-ports/2013-March/081979.html >> > and can not find the patch to download a make VBox work again on our >> > FBSD10 test server. >> > >> > Can You please send me a link to download the patch. >> > >> > Thanks in advance, >> > >> > Best Regards >> > >> > Ferenc Balku >> >> >> No problem I was "travel business... >> here is the patch, >> the list does not allow attach files... >> >> go to the /usr/ports/emulators/virtualbox-ose-kmod, >> put the fix in the "files" directory with a name like ==> >> patch-the-freebsd-kernel >> and do a make clean install >> ============================================================== >> --- src/VBox/Runtime/r0drv/freebsd/the-freebsd-kernel.h.orig >> 2012-12-19 16:27:29.000000000 -0200 >> +++ src/VBox/Runtime/r0drv/freebsd/the-freebsd-kernel.h 2013-03-09 >> 14:42:18.924039639 -0300 >> @@ -50,6 +50,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -70,6 +71,12 @@ >> #include >> #include >> >> +/* >> + fix VM_OBJ_LOCK >> +*/ >> +#define VM_OBJECT_LOCK(o) VM_OBJECT_RLOCK(o) >> +#define VM_OBJECT_UNLOCK(o) VM_OBJECT_RUNLOCK(o) > > This is definitely wrong. For the blind substitution, you should > use VM_OBJECT_WLOCK/VM_OBJECT_WUNLOCK. It would be great if someone could come up with a proper patch. All I've seen so far looks wrong or hackish and I cannot add that to the port nor send it upstream to get it fixed for future releases. -- Bernhard Froehlich http://www.bluelife.at/