From owner-freebsd-bugs@freebsd.org Sun Apr 18 23:47:40 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 768145DA40E for ; Sun, 18 Apr 2021 23:47:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4FNmpN2m7Bz4gWL for ; Sun, 18 Apr 2021 23:47:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 5EA0A5DA109; Sun, 18 Apr 2021 23:47:40 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5E66E5DA44D for ; Sun, 18 Apr 2021 23:47:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FNmpN29Ywz4gtL for ; Sun, 18 Apr 2021 23:47:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 39A56151B4 for ; Sun, 18 Apr 2021 23:47:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 13INleFr088036 for ; Sun, 18 Apr 2021 23:47:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 13INlelJ088035 for bugs@FreeBSD.org; Sun, 18 Apr 2021 23:47:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 255202] drawer.lua: brand positioning not working Date: Sun, 18 Apr 2021 23:47:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jlduran@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 23:47:40 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255202 Bug ID: 255202 Summary: drawer.lua: brand positioning not working Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: misc Assignee: bugs@FreeBSD.org Reporter: jlduran@gmail.com CC: kevans@freebsd.org, tsoome@freebsd.org Created attachment 224233 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D224233&action= =3Dedit Screenshot with spindle artifact drawer.lua ignores the values in `loader_brand_x` and `loader_brand_y`. I have attached a patch that *fixes* it, but I would like to request, if possible, some reviewing. I have also attached a screenshot, taken with the patch applied, however there's the spindle? artifact hanging around, and being shifted by the offsetting of the brand (indicated by the red arrow). I don't know how to address this. This can be replicated by creating two files: /boot/loader.conf.d/bootloader.conf: loader_logo=3D"none" loader_brand=3D"nakatomi" loader_brand_x=3D"15" /boot/lua/gfx-nakatomi.lua: return { brand =3D { image =3D "/boot/images/freebsd-logo-rev.png" } } Thank you! --=20 You are receiving this mail because: You are the assignee for the bug.=