From owner-freebsd-current@FreeBSD.ORG Tue Aug 12 14:06:22 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0A487CDE for ; Tue, 12 Aug 2014 14:06:22 +0000 (UTC) Received: from mail-yk0-x22d.google.com (mail-yk0-x22d.google.com [IPv6:2607:f8b0:4002:c07::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C095A24FA for ; Tue, 12 Aug 2014 14:06:21 +0000 (UTC) Received: by mail-yk0-f173.google.com with SMTP id 131so7173925ykp.32 for ; Tue, 12 Aug 2014 07:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=S5UJSzcbP/e2YGTYOl9e/Z/yD/dGS+GMaHJjuS6aFPQ=; b=E8XyGaufH+JSPuz1hr4retEgR4vAHde0dEA6pzorAUFXIQoUloOfpnEZQHNuLl7sJl SkmjjrZ/dURPzRkcdK5lpHc9hVcMSVrBZ2X0kHp0RvHjX2XTtcezX6ukgVR+WoUQ2b1C 2RN2Lm4kYLUoX/SDatmL9UaugR67e3KeCQAl5/BBl5sefNr3AtHOPYh4fyJw4gFmkH5F WLEO5GZ7Lbaw9LEIAhEwrIbbrT5sD/AdsNqiWAzzy08v5W5VaWxVW7QrYomFFVlSiriG fnjbbOjkMKdZtdbPCIpm+32uX/wPLLoPytTUUBw+Yf9WptNp81KB+Eekfo6uEo00O/8X dm/g== X-Received: by 10.236.83.103 with SMTP id p67mr51656630yhe.89.1407852380859; Tue, 12 Aug 2014 07:06:20 -0700 (PDT) Received: from zhabar.att.net (107-222-186-3.lightspeed.sntcca.sbcglobal.net. [107.222.186.3]) by mx.google.com with ESMTPSA id p55sm30231421yhh.34.2014.08.12.07.06.20 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Tue, 12 Aug 2014 07:06:20 -0700 (PDT) Date: Tue, 12 Aug 2014 07:06:16 -0700 From: Justin Hibbits To: Alexandr Krivulya Subject: Re: Child suspend/resume Message-ID: <20140812070616.62c66567@zhabar.att.net> In-Reply-To: <53E9CDD5.6020507@shurik.kiev.ua> References: <20140810223030.479badbc@zhabar.att.net> <53E9CDD5.6020507@shurik.kiev.ua> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.22; powerpc64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Aug 2014 14:06:22 -0000 Hi Alexandr, Thanks. I got another confirmation that it didn't work, and may have found the cause. I have another patch that you can find at https://phabric.freebsd.org/D590 which fixes a typo that I had made. Could you try that? (Added current@ so everyone else sees this as well). Thanks! - Justin On Tue, 12 Aug 2014 11:18:29 +0300 Alexandr Krivulya wrote: > Hi, Justin > After applying your patch my thinkpad e530 (FreeBSD 11.0-CURRENT, > amd64) doesn't resume any more - screen remains black. >=20 > 11.08.2014 08:30, Justin Hibbits (by way of Justin Hibbits > ) =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > Hi all, > > > > The attached patch is completely untested, due to lack of existing > > suspendable hardware (no x86 machines). It does compile cleanly > > against head, though. I don't think it should change any behavior, > > I tried to keep the essence of the code path the same. > > > > It was suggested that I break up my multipass suspend/resume code > > into incremental parts, so this is part one. It adds a > > BUS_SUSPEND_CHILD/BUS_RESUME_CHILD, as well as helper functions, > > bus_generic_suspend_child()/bus_generic_resume_child(), and modifies > > the PCI driver to use this new facility. > > > > I'd like some feedback, and testing of this, to make sure I didn't > > break anything. > > > > Thanks, > > Justin > > > > > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to > > "freebsd-current-unsubscribe@freebsd.org" >=20