From owner-svn-ports-head@freebsd.org Mon Jan 21 18:37:56 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B9E614B2D7E; Mon, 21 Jan 2019 18:37:56 +0000 (UTC) (envelope-from leres@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E77E870597; Mon, 21 Jan 2019 18:37:55 +0000 (UTC) (envelope-from leres@freebsd.org) Received: from ice.alameda.xse.com (unknown [IPv6:2001:558:6045:10:9084:9e0:4b6d:eb99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: leres) by smtp.freebsd.org (Postfix) with ESMTPSA id 31F482298; Mon, 21 Jan 2019 18:37:55 +0000 (UTC) (envelope-from leres@freebsd.org) Subject: Re: svn commit: r490700 - in head: . www/geolizer www/webalizer www/webalizer/files To: Adam Weinberger , sunpoet@freebsd.org References: <201901190708.x0J78MPd044747@repo.freebsd.org> <15960fbc-ffab-70fd-a248-d912c4b7ed3f@freebsd.org> Cc: Dirk Meyer , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Craig Leres Message-ID: Date: Mon, 21 Jan 2019 10:37:54 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E77E870597 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.97 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.99)[-0.989,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 18:37:56 -0000 On 1/19/19 8:22 PM, Adam Weinberger wrote: > On Sat, Jan 19, 2019 at 2:10 PM Craig Leres wrote: >> >> On 1/18/19 11:08 PM, Dirk Meyer wrote: >>> +20190119: >>> + AFFECTS: users of german/webalizer2, japanese/webalizer, polish/webalizer2, portuguese/webalizer-pt_BR, portuguese/webalizer-pt_PT, ukrainian/webalizer, www/geolizer, www/webalizer >>> + AUTHOR:dinoex@FreeBSD.org >>> + >>> + The option GEOIP has beeen changed to used the new datebase. >>> + Either copy GeoLite2-Country.mmdb in the working directory, >>> + or set the GeoIPDatabase option to the location of the file. >> >> Thanks for bringing geoip support back to webalizer! >> >> Would it be a good idea for UPDATING to also mention that >> net/geoipupdate is used to download the GeoLite2 version of the >> database? > > It's really net/libmaxminddb that should probably have that message, > because that is true for all GeoIP 2 users (Cc: sunpoet for this). Concur. But I also think putting something in UPDATING would be really helpful to people migrating from GeoIP 1 to 2. Certainly it took me a few minutes to figure out net/geoipupdate was what I needed to download the new format database files. >> Perhaps even include the new webalizer.conf GeoIPDatabase line: >> >> GeoIPDatabase /usr/local/share/GeoIP/GeoLite2-Country.mmdb > > It would make sense to me for that to be the default for webalizer. I agree with this as well. Craig