From owner-cvs-all@FreeBSD.ORG Wed Jan 4 00:17:08 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.ORG Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E0DB16A41F; Wed, 4 Jan 2006 00:17:08 +0000 (GMT) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C62543D55; Wed, 4 Jan 2006 00:17:07 +0000 (GMT) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.4/8.13.4) with ESMTP id k040H2wF044057; Wed, 4 Jan 2006 03:17:02 +0300 (MSK) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.13.4/8.13.4/Submit) id k040H2DM044056; Wed, 4 Jan 2006 03:17:02 +0300 (MSK) (envelope-from ache) Date: Wed, 4 Jan 2006 03:17:01 +0300 From: Andrey Chernov To: Diomidis Spinellis Message-ID: <20060104001701.GA44011@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Diomidis Spinellis , Poul-Henning Kamp , Diomidis Spinellis , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <88559.1136330180@critter.freebsd.dk> <43BB0D3B.10300@aueb.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43BB0D3B.10300@aueb.gr> User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.ORG, Poul-Henning Kamp , src-committers@FreeBSD.ORG, Diomidis Spinellis , cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_syscalls.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2006 00:17:08 -0000 On Wed, Jan 04, 2006 at 01:48:11AM +0200, Diomidis Spinellis wrote: > I saw that one coming :-) Solaris (SunOS 5.10) returns EINVAL, Mac OS X > Tiger and Linux 2.4.21 appear to ignore the field, and NetBSD 1.5 > follows our buggy behavior. POSIX is silent on the matter, and does not > specify EINVAL in the list of prescribed errno values > . Under no condition right code puts big values there (moreover, it is not portable, as you say above), so big values should be treated as error (with EINVAL) to stay on safe side. -- http://ache.pp.ru/