From owner-svn-src-head@FreeBSD.ORG Tue Mar 13 20:52:18 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C43771065672; Tue, 13 Mar 2012 20:52:18 +0000 (UTC) (envelope-from gonzo@hq.bluezbox.com) Received: from hq.bluezbox.com (hq.bluezbox.com [70.38.37.145]) by mx1.freebsd.org (Postfix) with ESMTP id 5CDB78FC27; Tue, 13 Mar 2012 20:52:17 +0000 (UTC) Received: from localhost ([127.0.0.1]) by hq.bluezbox.com with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.73 (FreeBSD)) (envelope-from ) id 1S7YJJ-000HwD-Dj; Tue, 13 Mar 2012 13:27:10 -0700 Message-ID: <4F5FADA3.4070902@freebsd.org> Date: Tue, 13 Mar 2012 13:27:15 -0700 From: Oleksandr Tymoshenko User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Marcel Moolenaar References: <201203060342.q263gs7g018067@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: gonzo@hq.bluezbox.com X-Spam-Level: ---- X-Spam-Report: Spam detection software, running on the system "hq.bluezbox.com", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: On 13/03/2012 9:21 AM, Marcel Moolenaar wrote: > > On Mar 5, 2012, at 7:42 PM, Oleksandr Tymoshenko wrote: >> @@ -308, 6 +308, 13 @@ _init_tls() >> } >> } >> >> +#ifdef TLS_VARIANT_I >> + /* >> + * tls_static_space should include space for TLS structure >> + */ >> + tls_static_space += TLS_TCB_SIZE; >> +#endif >> + > > How does this change behaviour on ia64 or powerpc? [...] Content analysis details: (-4.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 AWL AWL: From: address is in the auto white-list Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r232582 - head/lib/libc/gen X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2012 20:52:18 -0000 On 13/03/2012 9:21 AM, Marcel Moolenaar wrote: > > On Mar 5, 2012, at 7:42 PM, Oleksandr Tymoshenko wrote: >> @@ -308,6 +308,13 @@ _init_tls() >> } >> } >> >> +#ifdef TLS_VARIANT_I >> + /* >> + * tls_static_space should include space for TLS structure >> + */ >> + tls_static_space += TLS_TCB_SIZE; >> +#endif >> + > > How does this change behaviour on ia64 or powerpc? I believe it doesn't. nathanw@ performed some sanity tests on powerpc recently, and they passed. ia64 has not been tested. This issue manifested itself only with statically linked binaries. Juli presented some corner case test for MIPS that caused crash: binary compiled with "-static -pthread" without any actual thread- specific variables that tries to get TP pointer. This test case leads to crash and I used it for tracking down the root cause. For binaries with actual TLS data this issue would manifest itself as memory corruption.