From owner-freebsd-xen@freebsd.org Tue Dec 13 14:33:44 2016 Return-Path: Delivered-To: freebsd-xen@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E5404C75A37 for ; Tue, 13 Dec 2016 14:33:44 +0000 (UTC) (envelope-from prvs=148477600=roger.pau@citrix.com) Received: from SMTP.EU.CITRIX.COM (smtp.ctxuk.citrix.com [185.25.65.24]) (using TLSv1.2 with cipher RC4-SHA (128/128 bits)) (Client CN "mail.citrix.com", Issuer "DigiCert SHA2 Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6B10EB24 for ; Tue, 13 Dec 2016 14:33:43 +0000 (UTC) (envelope-from prvs=148477600=roger.pau@citrix.com) X-IronPort-AV: E=Sophos;i="5.33,341,1477958400"; d="scan'208";a="36710201" Date: Tue, 13 Dec 2016 14:29:19 +0000 From: freebsd xen To: liuyingdong CC: , , , Subject: Re: [PATCH]netfront: need release all resources after adding and removing NICs time and again Message-ID: <20161213142919.ulvvvwoz2da5fedw@dhcp-3-221.uk.xensource.com> References: <5825272C.3010704@huawei.com> <584F8F1C.6030006@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <584F8F1C.6030006@huawei.com> User-Agent: NeoMutt/20161126 (1.7.1) X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2016 14:33:45 -0000 On Tue, Dec 13, 2016 at 02:03:08PM +0800, liuyingdong wrote: > Hello Roger, > I want to know how about this patch,Please let me know if you have any questions. > Thanks. Hello, Thanks for the patches! This one is looking fine, it's just that I'm a little bit busy at the moment, and there are some issues in HEAD related to Xen that I would like to fix before pushing anything new. In any case, I see that you are sending the patches using Thunderbird, which is not ideal (MUAs tend to mangle patches). The preferred way for sending patches is using "git send-email"[0] directly. There are also several tutorials online that will help you setup git send-email correctly. If there's some reason why you can't use git send-email I would recommend that you also attach the patches directly to emails, that way they won't probably get mangled. Roger. [0] https://git-scm.com/docs/git-send-email