From owner-svn-src-all@freebsd.org  Wed Sep  2 19:15:22 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 424A79C9BBC;
 Wed,  2 Sep 2015 19:15:22 +0000 (UTC)
 (envelope-from cse.cem@gmail.com)
Received: from mail-yk0-f169.google.com (mail-yk0-f169.google.com
 [209.85.160.169])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0897616E;
 Wed,  2 Sep 2015 19:15:21 +0000 (UTC)
 (envelope-from cse.cem@gmail.com)
Received: by ykei199 with SMTP id i199so20702205yke.0;
 Wed, 02 Sep 2015 12:15:14 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=mime-version:reply-to:in-reply-to:references:date:message-id
 :subject:from:to:cc:content-type;
 bh=nxJeuOj6OcaEMZs2sR6ATv2qCaZUhqp0QvC8mVPgStM=;
 b=MI73JSIgWYSwsb03r03/qRWJ157Lu5102ywVFf7uzea0nm37M3SB9f1Vs8NJUCyx6N
 EdpoH6FW3Ck2loFDCwSb6z/kKquK3tppsW6OQSz44pIELcMwxzbYRz7V0vDe/bt+JEoQ
 RlWOns2gD9s5gFYDsjoTGw41z6jK5C6gv5HEitT+9TAQr9DJtXz1cv2pMRrL7ThyTqrd
 M4TzOt8/a3pN8lIlhH0WQ3Mq42GjrAJypvTlkrHB1PpoTEKciPDKSYB9l+i0WNDrbuHl
 Vdlv36q0DsTVT7ZNK3VEWSz58617F9JHGNpBXEO/jloIprHj1KKJLcLmWQncErj2pSiq
 RiMQ==
X-Received: by 10.170.130.145 with SMTP id w139mr5776983ykb.37.1441221314690; 
 Wed, 02 Sep 2015 12:15:14 -0700 (PDT)
Received: from mail-yk0-f169.google.com (mail-yk0-f169.google.com.
 [209.85.160.169])
 by smtp.gmail.com with ESMTPSA id t129sm21656372ywa.26.2015.09.02.12.15.14
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 02 Sep 2015 12:15:14 -0700 (PDT)
Received: by ykdg206 with SMTP id g206so20639863ykd.1;
 Wed, 02 Sep 2015 12:15:14 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.170.174.136 with SMTP id q130mr5987474ykd.126.1441221314211; 
 Wed, 02 Sep 2015 12:15:14 -0700 (PDT)
Reply-To: cem@FreeBSD.org
Received: by 10.37.48.134 with HTTP; Wed, 2 Sep 2015 12:15:14 -0700 (PDT)
In-Reply-To: <3589074.YABE6tqvK0@ralph.baldwin.cx>
References: <201509021648.t82Gm451015184@repo.freebsd.org>
 <3589074.YABE6tqvK0@ralph.baldwin.cx>
Date: Wed, 2 Sep 2015 12:15:14 -0700
Message-ID: <CAG6CVpUwYkd6Dv=LMbVm7KE_QJtMMYwcoXsG3shFj56asUP-PQ@mail.gmail.com>
Subject: Re: svn commit: r287403 - head/sys/dev/ioat
From: Conrad Meyer <cem@FreeBSD.org>
To: John Baldwin <jhb@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org, jimharris@freebsd.org
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Sep 2015 19:15:22 -0000

On Wed, Sep 2, 2015 at 10:26 AM, John Baldwin <jhb@freebsd.org> wrote:
> Alternatively you could use pci_restore_state() (before reset) and
> pci_save_state() (after reset) to restore standard PCI config registers
> (including MSI/MSI-X) after a reset.
>
> This might be more scalable if you want to ensure other PCI config
> registers (e.g. PCI-e capabilities) are restored after a reset.


Hi John,

Do you mean pci_save_state() before reset and pci_restore_state()
afterwards? Seems reasonable to me.

Thanks,
Conrad