From owner-cvs-src@FreeBSD.ORG Thu Nov 20 17:25:08 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CA2FB16A4CE; Thu, 20 Nov 2003 17:25:08 -0800 (PST) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2011043FE0; Thu, 20 Nov 2003 17:25:03 -0800 (PST) (envelope-from marcel@xcllnt.net) Received: from dhcp01.pn.xcllnt.net (dhcp01.pn.xcllnt.net [192.168.4.201]) by ns1.xcllnt.net (8.12.9/8.12.9) with ESMTP id hAL1P2EG002246; Thu, 20 Nov 2003 17:25:02 -0800 (PST) (envelope-from marcel@piii.pn.xcllnt.net) Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1]) hAL1P2dL001016; Thu, 20 Nov 2003 17:25:02 -0800 (PST) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp01.pn.xcllnt.net (8.12.10/8.12.10/Submit) id hAL1P2gZ001015; Thu, 20 Nov 2003 17:25:02 -0800 (PST) (envelope-from marcel) Date: Thu, 20 Nov 2003 17:25:02 -0800 From: Marcel Moolenaar To: Nate Lawson Message-ID: <20031121012502.GA914@dhcp01.pn.xcllnt.net> References: <20031120153849.H72721@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031120153849.H72721@root.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: John Baldwin Subject: Re: cvs commit: src/sys/dev/acpica acpi.c acpi_cpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Nov 2003 01:25:08 -0000 On Thu, Nov 20, 2003 at 03:40:58PM -0800, Nate Lawson wrote: > On Thu, 20 Nov 2003, John Baldwin wrote: > > On 20-Nov-2003 Nate Lawson wrote: > > > On Wed, 19 Nov 2003, John Baldwin wrote: > > >> One minor suggestion btw. Could you fix the hw.acpi.cpu.cpu_cx_lowest > > >> to use the "C1", "C2", and "C3" strings for its user-visible interface > > >> instead of the direct integer? Setting the value to C2 is a bit more > > >> intuitive than setting it to 1 to get C2. > > > > > > I considered this before, however Cx is really a type, not a given state. > > > There can be more than 3 sleep states. For instance, the IBM R40 has C1, > > > C2, C3, and C3 (4 states). An index was the only unique way I could > > > specify the states. The transition latency is also unique but setting a > > > state to 182 to get the last C3 state is even worse from a user > > > perspective. > > > > Ah. Maybe rename the sysctl/tunable to indicate that it is an index? > > No good ideas over here. Took me a while to even come up with > hw.acpi.cpu.cx_lowest. You want to indicate higher states will be also > used as determined by the scheduling algorithm and that states with higher > indices provide more power savings but also more latency. cx_lowest_idx > seems kinda lame. Suggestions? Maybe make the Cx state type an "unimportant" attribute? MIB-like: hw.acpi.cpu.cx.count=4 hw.acpi.cpu.cx.lowest=0 hw.acpi.cpu.cx.0.type=C1 hw.acpi.cpu.cx.0.latency=1 hw.acpi.cpu.cx.0.longsleep=x hw.acpi.cpu.cx.0.shortsleep=y hw.acpi.cpu.cx.1.type=C2 : hw.acpu.cpu.cx.2.type=C3 : hw.acpu.cpu.cx.3.type=C3 : Something like this makes the sysctl variables less magical, better to parse mechanically and puts the emphasis on the index. It's more verbose though... $0.02 -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net