Date: Tue, 22 Sep 2009 12:37:40 GMT From: Keith Gaughan <k@stereochro.me> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/139060: devel/gearmand: Maintainer patch was missing proper libmemcached support Message-ID: <200909221237.n8MCbeCA068223@www.freebsd.org> Resent-Message-ID: <200909221240.n8MCe3JX025665@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 139060 >Category: ports >Synopsis: devel/gearmand: Maintainer patch was missing proper libmemcached support >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Sep 22 12:40:03 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Keith Gaughan >Release: 7.1-RELEASE >Organization: >Environment: FreeBSD lir 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Thu Jan 1 14:37:25 UTC 2009 root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: In the PR ports/138614, the changes I submitted to devel/gearmand included changes to allow for proper libmemcached support. However, the maintainer only included the dependency on the libmemcached client library, which meant that while libmemcached would correctly be installed before the build of gearman, the configure script for gearman would not be able to detect its presence, so leaving devel/gearman with a useless dependency. I am therefore attempting to get part of my original patch that was left out applied. >How-To-Repeat: Build devel/gearman and monitor the output of the the configure script. You'll notice the following line: checking for libmemcached... no Thus indicating that the configure script was unable to properly detect the presence of libmemcached. >Fix: The problem is in how the configure script is attempting to detect libmemcached, and the patch corrects the buggy test to call the correct functions. (I'll be submitting a patch to the gearman developers shortly to fix this problem on their end.) The patch also instructs the configure script not to attempt to run tests against memcached itself as memcached is not guaranteed to be installed, and gearman doesn't need a dependency on it to build or run. Patch attached with submission follows: diff -urN gearman.orig/Makefile gearman/Makefile --- gearman.orig/Makefile 2009-09-22 13:21:31.000000000 +0100 +++ gearman/Makefile 2009-09-22 13:25:07.000000000 +0100 @@ -7,6 +7,7 @@ PORTNAME= gearmand PORTVERSION= 0.9 +PORTREVISION= 1 CATEGORIES= devel MASTER_SITES= http://launchpad.net/gearmand/trunk/${PORTVERSION}/+download/ @@ -289,6 +290,8 @@ .include <bsd.port.pre.mk> +CONFIGURE_ARGS+= --without-memcached + .ifdef(WITH_PQ) PLIST_SUB+= PG="" CONFIGURE_ARGS+= --with-libpq-prefix diff -urN gearman.orig/files/patch-configure gearman/files/patch-configure --- gearman.orig/files/patch-configure 1970-01-01 01:00:00.000000000 +0100 +++ gearman/files/patch-configure 2009-09-22 13:21:02.000000000 +0100 @@ -0,0 +1,11 @@ +--- configure.orig 2009-09-07 15:34:37.000000000 +0100 ++++ configure 2009-09-07 15:34:21.000000000 +0100 +@@ -24161,7 +24161,7 @@ + + memcached_st memc; + memcached_dump_func *df; +- memcached_version(); ++ memcached_lib_version(); + + ; + return 0; >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200909221237.n8MCbeCA068223>