Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 08 Apr 2002 23:54:59 -0600 (MDT)
From:      "M. Warner Losh" <imp@village.org>
To:        obrien@FreeBSD.org
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/sys ioccom.h
Message-ID:  <20020408.235459.112894298.imp@village.org>
In-Reply-To: <200204090517.g395Hi385293@freefall.freebsd.org>
References:  <200204090517.g395Hi385293@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200204090517.g395Hi385293@freefall.freebsd.org>
            "David E. O'Brien" <obrien@FreeBSD.org> writes:
:   Back out rev 1.11.  People want a FUBARed prototype that breaks many
:   things.

The reason that vim broke is because it includes a bunch of system
headers and tries to find the following pattern for each prototype:

sed < $srcdir/osdef1.h.in -n -e '/^extern/s@.*[)*       ][)*    ]*\([a-zA-Z_][a-zA-Z0-9_]*\) __ARGS.*@/[)*,     ]\1[    (]/i\\\
\\/\\[^a-zA-Z_\\]\1 __ARGS\\/d@p' > osdef11.sed

followed by:

cat osdef0.ccc | sed -n -f osdef11.sed >> osdef2.sed
sed -f osdef2.sed < $srcdir/osdef1.h.in > auto/osdef.h

which is failing to find the prototype....  Not the best thing for a
configuration utility to assume.  That's why 1.11 broke things for
vim, and hylafax.  when it failed to find a prototype with the above
regular expression, it defined a prototype.  I think that maybe the
following will fix it:

sed < $srcdir/osdef1.h.in -n -e '/^extern/s@.*[)*       ][)*    ]*\([a-zA-Z_][a-zA-Z0-9_]*\) __ARGS.*@/[)*,     ][(]*\1[)]*[    (]/i\\\
\\/\\[^a-zA-Z_\\]\1 __ARGS\\/d@p' > osdef11.sed

Since it allows the new prototypes to match.  Likewise for osdef2.h.in
elsewhere in the file.  Or take the low road and just remove ioctl
from the osdef1.h.in file...

Of course if X were easier to compile/recompile, I'd take a shot at
fixing it too, but the new meta ports make that hard :-(.

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020408.235459.112894298.imp>