From owner-freebsd-scsi Mon Aug 12 20:11:53 2002 Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BEBFC37B400 for ; Mon, 12 Aug 2002 20:11:50 -0700 (PDT) Received: from aslan.scsiguy.com (aslan.scsiguy.com [63.229.232.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9AEB143E6A for ; Mon, 12 Aug 2002 20:11:49 -0700 (PDT) (envelope-from gibbs@scsiguy.com) Received: from aslan.scsiguy.com (aslan.scsiguy.com [63.229.232.106]) by aslan.scsiguy.com (8.12.5/8.12.5) with ESMTP id g7D3BaZs012144; Mon, 12 Aug 2002 21:11:43 -0600 (MDT) (envelope-from gibbs@scsiguy.com) Date: Mon, 12 Aug 2002 21:11:36 -0600 From: "Justin T. Gibbs" To: Joerg Wunsch , freebsd-scsi@FreeBSD.org Subject: Re: Tekram DC-395 driver maintenance Message-ID: <189710000.1029208296@aslan.scsiguy.com> In-Reply-To: <20020811103649.G39683@uriah.heep.sax.de> References: <20020811103649.G39683@uriah.heep.sax.de> X-Mailer: Mulberry/2.2.1 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org > In the course of investigating his problems, i eventually found out > that there was one serious bug in that driver: ... > Still, the code looks a bit strange to us (Hungarian notation, 4-position > hard tabs) since it's just vendor-supplied code. ... > Would anybody have strong objections for me to import the code into > our tree, under the promise that i could keep track of future vendor > submissions? I took a stab a long time ago at cleaning up one of the Tekram supplied drivers. I really had a hard time putting down the urge to just rototil it to fix various structural and SCSI protocol deficiencies. I would prefer for you to really fixup the driver prior to bringing it into the tree, but barring that, I won't object to you just importing it as is. -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message