From owner-freebsd-hackers@FreeBSD.ORG Tue Apr 18 18:38:18 2006 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C371D16A404 for ; Tue, 18 Apr 2006 18:38:18 +0000 (UTC) (envelope-from anderson@centtech.com) Received: from mh1.centtech.com (moat3.centtech.com [207.200.51.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45E0443D49 for ; Tue, 18 Apr 2006 18:38:18 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from [10.177.171.220] (neutrino.centtech.com [10.177.171.220]) by mh1.centtech.com (8.13.1/8.13.1) with ESMTP id k3IIc8rD008663; Tue, 18 Apr 2006 13:38:08 -0500 (CDT) (envelope-from anderson@centtech.com) Message-ID: <44453204.3030906@centtech.com> Date: Tue, 18 Apr 2006 13:37:56 -0500 From: Eric Anderson User-Agent: Thunderbird 1.5 (X11/20060402) MIME-Version: 1.0 To: cokane@cokane.org References: <444515C8.3030406@centtech.com> <20060418165709.GA17705@central.0xfce3.net> <44452532.40703@centtech.com> <20060418.114933.69380798.imp@bsdimp.com> <346a80220604181102v3597a1edp3e05fa663b87e15c@mail.gmail.com> In-Reply-To: <346a80220604181102v3597a1edp3e05fa663b87e15c@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.87.1/1404/Tue Apr 18 05:03:40 2006 on mh1.centtech.com X-Virus-Status: Clean Cc: gbergling@0xfce3.net, freebsd-hackers@freebsd.org Subject: Re: [PATCH] Fancy rc startup style RFC X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2006 18:38:19 -0000 Coleman Kane wrote: > On 4/18/06, *M. Warner Losh* > wrote: > > In message: <44452532.40703@centtech.com > > > Eric Anderson > writes: > : Gordon Bergling wrote: > : > Hi, > : > > : > * Thus spake Eric Anderson (anderson@centtech.com > ): > : >> I've made a patch to /etc/rc.subr that makes the > startup/shutdown rc > : >> scripting look similar to other OS's (many different linux > distros, > : >> HP-UX, etc), but without color. > : >> > : >> The patch shouldn't break anything, and is only enabled if you > have this > : >> in your /etc/rc.conf: > : >> > : >> rc_fancy="YES" > : >> > : >> Several of the /etc/rc.d/* scripts send output to stdout, so > that could > : >> be cleaned up a bit if needed, but for now I tried to keep the > patch as > : >> minimal as possible. > : >> > : >> This is still a first pass, so please give feedback. > : > > : > A short try on my notebook shows some errors. > : > I don't want to let this email getting too big, so I put the > "dmesg -a" > : > output online. http://generic.0xfce3.net/dmesg-fancy.txt > : > > : > BTW, the patch applied cleanly. > : > : > : Thanks for the feedback! Looks like I made an erroneous > assumption that > : the wc, expr, and printf tools found in /usr/bin and /bin would be > : available through boot, but that isn't the case on systems with those > : file systems separate from /. I'm not sure how to resolve some of > these > : issues, since I don't know of a way to do those functions in csh > without > : them. I'm open to suggestions here from anyone. > > /bin and /sbin are available through the entire boot. Only things in > /usr are suspect because /usr gets mounted early in the boot process, > but not as early as /. > > Warner > > > Nice work! > > I too noticed the dependence upon wc, printf, expr. I went ahead and > rewrote these into equivalents in native sh. (attaching new diff). > > This diff is against the latest 7-CURRENT rc.subr. I had to manually > merge 3 hunks due to some differences. Thanks!! I've put the updated version (for 6-STABLE) here: http://www.googlebit.com/freebsd/patches/rc_fancy.patch-2 Gordon - can you give this version a try? Thanks, Eric -- ------------------------------------------------------------------------ Eric Anderson Sr. Systems Administrator Centaur Technology Anything that works is better than anything that doesn't. ------------------------------------------------------------------------