From owner-svn-src-head@freebsd.org Wed Jan 4 18:20:39 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67B3EC9FBFF; Wed, 4 Jan 2017 18:20:39 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt0-x241.google.com (mail-qt0-x241.google.com [IPv6:2607:f8b0:400d:c0d::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 210D21CAE; Wed, 4 Jan 2017 18:20:39 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt0-x241.google.com with SMTP id 3so40671097qtr.2; Wed, 04 Jan 2017 10:20:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OuKROI8huaDqyx6t+5D+i2PKMp5f0B2NSr0HsogC2gA=; b=P/Tc7Fu0y8q0LgF51bixBiN0ZgnE/+YIU8B5AebSHo8/fBA8ncIvGwdSTTZ0eFuW0y xjt2j5/cYvOihGhcqMsW/X1IkP2Q5fEdp1T0O8Gv9jgD8Fm7/sFBDGuVzEexY6taZuPd pokYngRf3r/Owp30ihOJkmvIUKm1qAA1tb99q7FcLz9q5un6jEDjIK/LuynF+oMZ/OsO F2A9Tuw8CTvCwnyu+1hV5KKCjvbuSMqRnMSYOV6P0VG/rMEHccfXJsj5G5l0v+n5oH8l laonRUQU9vrqj3J4hdq26OOyJIIEEvw2xOVnwEP3ENdBsDoAVMfI7nQkm/a6S3ErdcJk hh7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=OuKROI8huaDqyx6t+5D+i2PKMp5f0B2NSr0HsogC2gA=; b=FFJh6AtoJZ9A42Efr9LxmaFoL54vKdLUixc0NcZrDxklow9QeNUFIzJVABaEPlINmP yLzpPixELCiVgm7Mj0OcHiE7H+kfG8RYYRIegHWtsDzsJN30fCWgk+JBTbym/4+DWi/J HzCI5QyoXPZb9SQYE1nZZhA04pjImO6m7MuDRGs7U/9KSluerbDv5vkOx6yN11gq3rUZ VJCkxvj/2Se3VCnlSdqfWCD4CZjFrvFedlMDiQp69RAAE5kmc0WtkMua1FEfJIUJC4+I LjrxTP6TX2dHhj70SsVUP7u3hb9uwDYCkgdg0V99gONCkA4eyv75Iuq8SWlxkiOuN4At 6H3Q== X-Gm-Message-State: AIkVDXKRNvLCIyspzbtkY0A9UnJ69uN5bK46BMslz/ucYjE2HvSYe7N1nh1Hhq4Q93cmKg== X-Received: by 10.237.36.12 with SMTP id r12mr64174447qtc.97.1483554037990; Wed, 04 Jan 2017 10:20:37 -0800 (PST) Received: from wkstn-mjohnston.west.isilon.com (c-76-104-201-218.hsd1.wa.comcast.net. [76.104.201.218]) by smtp.gmail.com with ESMTPSA id q62sm42977817qkb.46.2017.01.04.10.20.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jan 2017 10:20:37 -0800 (PST) Sender: Mark Johnston Date: Wed, 4 Jan 2017 10:26:30 -0800 From: Mark Johnston To: "George V. Neville-Neil" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r311225 - head/sys/netinet Message-ID: <20170104182630.GA26522@wkstn-mjohnston.west.isilon.com> References: <201701040219.v042JDEk026544@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201701040219.v042JDEk026544@repo.freebsd.org> User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 18:20:39 -0000 On Wed, Jan 04, 2017 at 02:19:13AM +0000, George V. Neville-Neil wrote: > Author: gnn > Date: Wed Jan 4 02:19:13 2017 > New Revision: 311225 > URL: https://svnweb.freebsd.org/changeset/base/311225 > > Log: > Fix DTrace TCP tracepoints to not use mtod() as it is both unnecessary and > dangerous. Those wanting data from an mbuf should use DTrace itself to get > the data. I think you also need to update the types in in_kdtrace.c, and add a translator for struct mbuf * to ipinfo_t.