From owner-svn-src-all@freebsd.org Mon Dec 19 18:58:44 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15D8EC88A7C for ; Mon, 19 Dec 2016 18:58:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D4FEC1CE4 for ; Mon, 19 Dec 2016 18:58:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x244.google.com with SMTP id f73so20010620ioe.2 for ; Mon, 19 Dec 2016 10:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=P/ci+APtB4GbDjWcAW4TODiPAZc9Dl/8ICnDOqU4ZTA=; b=H5y6y9iNktDIpYTs+YL08tBbL2xAxRtdDehBcO4OupdZmqONSu0zjoONzmn0n13Svh 8OEKbV7JXt+n7+RpnKUb87meppIZUdK6g9mJjr2grlo8FNImdW17gvgRIW05GUUuAGOz s4f8OWvjVqj4A+W2DnbF3A+MRKWpEXu3NWqoSQxZ9h2mBPaGGUMWbfXUywSRgmKXgbXO lYtjBCJxVgdO+MLMe5Ehacm11Df3T5IRpsYLmUMQZkcT5FVzeDiX0js/IDtyZA2SkwcD buIlvJIWxLx3gqAT7byfxmRaD5l9hujQZvwHud0q4i3daAeVD0XGizqQD66Dyv6VQv38 5fzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=P/ci+APtB4GbDjWcAW4TODiPAZc9Dl/8ICnDOqU4ZTA=; b=drSaHQGWCo4uFUNlHW6unoRYmdsaEP3Dw+u/SZBeYhi3xJQD1CBeBvXEm+LUdslY3l dbzS7ekZxyHiohq+jyWVgqu6Vj6S01Bx5X762cDpA62KCkxjOnKz0eybThdK4vs7s0/6 bjwc8POUi8SqhvjY3uuiM9wrF6NS2vJq0gLR7ay9pklk8LsDxGxQX84GOxoowPwta/Ys CnY8p9PeBg0YgiZxtDjm/kh60K3BSH/zimS+ljPvhkZKsYjdWb8FFRjxviy4Tfl7y+/m U9zUu0obvoXVsouW67/wgMWKdkPFjvDRO/mjU89+wSFvAFzTnQK//bPePCX8nt0AR3D7 oFNg== X-Gm-Message-State: AIkVDXLUY3d5GCa2RsiPU7fulTtXL+xC/Hkzx1Wk48bA1mfd6yCq9KpoCP1g8X03wer4t4S6kPbeLZeEB67VTg== X-Received: by 10.107.132.74 with SMTP id g71mr16685192iod.19.1482173923157; Mon, 19 Dec 2016 10:58:43 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.22.135 with HTTP; Mon, 19 Dec 2016 10:58:42 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: <9BD5034F-55A6-48F6-A391-A0877FF49702@panasas.com> References: <201612161949.uBGJnMol059217@repo.freebsd.org> <9BD5034F-55A6-48F6-A391-A0877FF49702@panasas.com> From: Warner Losh Date: Mon, 19 Dec 2016 11:58:42 -0700 X-Google-Sender-Auth: fpAmNcP9Tg6kZ06GkJhovOIRnoc Message-ID: Subject: Re: svn commit: r310171 - head/sys/sys To: Ravi Pokala Cc: Sepherosa Ziehau , Dimitry Andric , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 18:58:44 -0000 On Mon, Dec 19, 2016 at 1:39 AM, Ravi Pokala wrote: > -----Original Message----- >> From: on behalf of Sepherosa Ziehau >> Date: 2016-12-18, Sunday at 23:02 >> To: Dimitry Andric >> Cc: , , >> Subject: Re: svn commit: r310171 - head/sys/sys >> >> The following patch unbreaks the LINT builds on amd64 for me after this commit: >> https://people.freebsd.org/~sephe/geom_sscanf.diff > > Wouldn't it be better to use the SCN macros? Are there other precedence for avoiding the SCN macros in the tree as well, or is this new art? Warner >> Thanks, >> sephe >> >> >> On Sat, Dec 17, 2016 at 3:49 AM, Dimitry Andric wrote: >>> Author: dim >>> Date: Fri Dec 16 19:49:22 2016 >>> New Revision: 310171 >>> URL: https://svnweb.freebsd.org/changeset/base/310171 >>> >>> Log: >>> Add __scanflike attributes to the kernel's sscanf() and vsscanf() >>> declarations. This should help to catch future mismatches between >>> format strings and arguments. >>> >>> MFC after: 1 week >>> >>> Modified: >>> head/sys/sys/systm.h >>> >>> Modified: head/sys/sys/systm.h >>> ============================================================================== >>> --- head/sys/sys/systm.h Fri Dec 16 19:09:57 2016 (r310170) >>> +++ head/sys/sys/systm.h Fri Dec 16 19:49:22 2016 (r310171) >>> @@ -227,8 +227,8 @@ int vsnprintf(char *, size_t, const char >>> int vsnrprintf(char *, size_t, int, const char *, __va_list) __printflike(4, 0); >>> int vsprintf(char *buf, const char *, __va_list) __printflike(2, 0); >>> int ttyprintf(struct tty *, const char *, ...) __printflike(2, 3); >>> -int sscanf(const char *, char const *, ...) __nonnull(1) __nonnull(2); >>> -int vsscanf(const char *, char const *, __va_list) __nonnull(1) __nonnull(2); >>> +int sscanf(const char *, char const *, ...) __nonnull(1) __nonnull(2) __scanflike(2, 3); >>> +int vsscanf(const char *, char const *, __va_list) __nonnull(1) __nonnull(2) __scanflike(2, 0); >>> long strtol(const char *, char **, int) __nonnull(1); >>> u_long strtoul(const char *, char **, int) __nonnull(1); >>> quad_t strtoq(const char *, char **, int) __nonnull(1); >>> _______________________________________________ >>> svn-src-all@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/svn-src-all >>> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >> >> -- >> Tomorrow Will Never Die > > > >