From owner-svn-ports-all@freebsd.org  Tue Jul 12 01:24:03 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32D31B83824;
 Tue, 12 Jul 2016 01:24:03 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 24AD817CF;
 Tue, 12 Jul 2016 01:24:03 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 2352B1215; Tue, 12 Jul 2016 01:24:03 +0000 (UTC)
Date: Tue, 12 Jul 2016 01:24:03 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Kurt Jaeger <pi@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r418403 - in head/mail: . jwsmtp
Message-ID: <20160712012403.GA86788@FreeBSD.org>
References: <201607112014.u6BKEUXC057507@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201607112014.u6BKEUXC057507@repo.freebsd.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jul 2016 01:24:03 -0000

On Mon, Jul 11, 2016 at 08:14:30PM +0000, Kurt Jaeger wrote:
> New Revision: 418403
> URL: https://svnweb.freebsd.org/changeset/ports/418403

Kurt,

> Log:
>   New port: mail/jwsmtp
>   [...]
>   
> +NO_OPTIONS_SORT=	yes

May I ask what's the point of this line in this particular case?

> +OPTIONS_DEFINE=		DOCS MANPAGES
> +OPTIONS_DEFAULT=	DOCS MANPAGES

DOCS is already in the default option set, no need to put it here again.
And we normally do not conditionalize manpages unless they are actually
being *built* with some heavy stuff like LaTeX or something.

Notice that in r416385 you've made a similar mistake of putting IPV6 on
default options list.  Please review `Mk/bsd.options.mk' to see what how
this list is being initialized.

> +DOCS_DESC=	Install documentation
> +MANPAGES_DESC=	Install manpages

We have both definitions in the default pull; "manpages" is more of a
slang form (should've been spelled as "manual pages" in this context),
but then again -- manpages should be just intalled, no option needed.

> +.if ${PORT_OPTIONS:MDOCS}
> +PLIST_SUB+=	PORTDOCS=""
> +.else
> +PLIST_SUB+=	PORTDOCS="@comment "
> +.endif
> +
> +.if ${PORT_OPTIONS:MMANPAGES}
> +PLIST_SUB+=	MANPAGES=""
> +.else
> +PLIST_SUB+=	MANPAGES="@comment "
> +.endif

OPTIONS_SUB would've saved you the trouble here.

./danfe