From owner-freebsd-net@FreeBSD.ORG Mon Nov 18 19:26:32 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2AEC039A; Mon, 18 Nov 2013 19:26:32 +0000 (UTC) Received: from am1outboundpool.messaging.microsoft.com (am1ehsobe005.messaging.microsoft.com [213.199.154.208]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B007421B0; Mon, 18 Nov 2013 19:26:31 +0000 (UTC) Received: from mail61-am1-R.bigfish.com (10.3.201.231) by AM1EHSOBE023.bigfish.com (10.3.207.145) with Microsoft SMTP Server id 14.1.225.22; Mon, 18 Nov 2013 19:26:24 +0000 Received: from mail61-am1 (localhost [127.0.0.1]) by mail61-am1-R.bigfish.com (Postfix) with ESMTP id 09F034A0077; Mon, 18 Nov 2013 19:26:24 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.239.16; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF02-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: -5 X-BigFish: VPS-5(zzdb82h98dI9371I1432I168aJzz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h1d1ah1d2ah1fc6hzz8275ch1de098h17326ah8275bh8275dh1de097h186068hz31h2a8h839h944hd24hd2bhf0ah1220h1288h12a5h12a9h12bdh137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh224fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1e23h1fe8h1ff5h2218h2216h1155h) Received-SPF: softfail (mail61-am1: transitioning domain of juniper.net does not designate 66.129.239.16 as permitted sender) client-ip=66.129.239.16; envelope-from=stevek@juniper.net; helo=P-EMF02-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail61-am1 (localhost.localdomain [127.0.0.1]) by mail61-am1 (MessageSwitch) id 1384802781858872_8170; Mon, 18 Nov 2013 19:26:21 +0000 (UTC) Received: from AM1EHSMHS004.bigfish.com (unknown [10.3.201.244]) by mail61-am1.bigfish.com (Postfix) with ESMTP id CD03040006E; Mon, 18 Nov 2013 19:26:21 +0000 (UTC) Received: from P-EMF02-SAC.jnpr.net (66.129.239.16) by AM1EHSMHS004.bigfish.com (10.3.207.104) with Microsoft SMTP Server (TLS) id 14.16.227.3; Mon, 18 Nov 2013 19:26:21 +0000 Received: from stevek-ubuntu (172.25.4.212) by P-EMF02-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server id 14.3.146.0; Mon, 18 Nov 2013 11:26:19 -0800 Date: Mon, 18 Nov 2013 14:26:16 -0500 From: Steve Kiernan To: Eitan Adler Subject: Re: [JNPR] Network stack as a module (RFC) Message-ID: <20131118142616.354526ae@stevek-ubuntu> In-Reply-To: References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> Organization: Juniper Networks Inc. X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: "freebsd-net@freebsd.org" , luigi@freebsd.org, Marcel Moolenaar , zec@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2013 19:26:32 -0000 On Sat, 16 Nov 2013 21:41:26 -0500 Eitan Adler wrote: > On Fri, Nov 15, 2013 at 4:52 PM, Steve Kiernan wrote: > > This is a follow up to the request sent back in January titled "Proposal for changes to network device drivers and network stack". > > > > In order to make it easier to review, we will be submitting pieces to be contributed in logical blocks. > > > > Please review the following patch and provide feedback: > > http://people.freebsd.org/~marcel/Juniper/201311/netstack-option.diff > > There are a few empty #ifdef blocks: such as in sys/compat/svr4/svr4_proto.h > > > +#ifdef NETSTACK > +#else > +#endif > +#ifdef NETSTACK > +#else > +#endif > +#ifdef NETSTACK > +#else > +#endif > +#ifdef NETSTACK > +#else > +#endif > > Do we need these? These are artifacts of running "make sysent" in the sys/compat/svr4 directory. Since the file says "DO NOT EDIT", I left those additions alone. -- Stephen J. Kiernan Juniper Networks, Inc. stevek_at_juniper.net