From owner-svn-ports-all@freebsd.org  Mon Apr 29 06:56:08 2019
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1CDD01582D20;
 Mon, 29 Apr 2019 06:56:08 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A54E78EAAA;
 Mon, 29 Apr 2019 06:56:07 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 8E82E16C0D; Mon, 29 Apr 2019 06:56:07 +0000 (UTC)
Date: Mon, 29 Apr 2019 06:56:07 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: "Tobias C. Berner" <tcberner@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r500363 - in head/sysutils: . etc_os-release
Message-ID: <20190429065607.GA55169@FreeBSD.org>
References: <201904281922.x3SJMLo2013472@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201904281922.x3SJMLo2013472@repo.freebsd.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: A54E78EAAA
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.94 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_SHORT(-0.94)[-0.942,0]; REPLY(-4.00)[];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Apr 2019 06:56:08 -0000

On Sun, Apr 28, 2019 at 07:22:21PM +0000, Tobias C. Berner wrote:
> New Revision: 500363
> URL: https://svnweb.freebsd.org/changeset/ports/500363
> 
> Log:
>   New port: sysutils/etc_os-release

Perhaps `misc' would've been a better category, since it's not strictly
an utility.  Missed this in the review, sorry.

> +CONTENTS=	'NAME=FreeBSD\0'$\
> +		'VERSION=${VERSION}\0'$\
> +		'ID=${VERSION_ID}\0'$\
> +		'VERSION_ID=freebsd\0'$\
> +		'ANSI_COLIR="0;31"\0'$\
> +		'PRETTY_NAME="FreeBSD ${VERSION}"\0'$\
> +		'CPE_NAME=cpe:/o:freebsd:freebsd:${VERSION_ID}\0'$\
> +		'HOME_URL=https://freebsd.org/\0'$\
> +		'BUG_REPORT_URL=https://bugs.freebsd.org'

Oh, this is so ugly.  Please consider something like this:

CONTENTS=       "NAME=FreeBSD" \
                "VERSION=${VERSION}" \
                "VERSION_ID=${VERSION_ID}" \
                "ID=${OPSYS:tl}" \
                "ANSI_COLOR=\\\"0;31\\\"" \
                "PRETTY_NAME=\\\"${OPSYS}\ ${VERSION}\\\"" \
                "CPE_NAME=cpe:/o:freebsd:freebsd:${VERSION_ID}" \
                "HOME_URL=https://freebsd.org/" \
                "BUG_REPORT_URL=https://bugs.freebsd.org"

Then you don't need -0 for xargs(1) and there's no extra newline at EOF.

./danfe