From owner-svn-src-all@FreeBSD.ORG Tue Mar 10 19:39:51 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A126ED88 for ; Tue, 10 Mar 2015 19:39:51 +0000 (UTC) Received: from nm20-vm6.bullet.mail.gq1.yahoo.com (nm20-vm6.bullet.mail.gq1.yahoo.com [98.136.217.37]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 684CD2B2 for ; Tue, 10 Mar 2015 19:39:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1426016013; bh=4fVgvH59rcAbfTTOTaf1eOb+PZhRRVxukU3ITWx8PsI=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject; b=U35Kmqg884SbvaBcXP5cWrE/v/BzPIy4GMejy8tZNlvds3kycLFnI+ev7kzXgz7RphalcJUmnjnvJEPZ4mli+Y7HXU+xVtjZWFwxSrGG0IeGqKvEPFC44PmNgDXZZFjwSr7GGt49FxTmVsu72nBroU1tXQw068zlw9pd1Ibek9IlzOmQrSGcy2U3p9KRiB4tnHgmz9bplh6ZGi1nP52kBVMM6BymDyDYQXMLBL6xAKU2v9ofnJW1A/oIq8v6RGlPNI7b9aOcZf05BJVpBJfZszeWi+0BqE5rSjEXrXPicmOx9LyiqtqvG3Pr3XB2Su3xt6IiFndkF6B4R4OHXzKWFg== Received: from [98.137.12.59] by nm20.bullet.mail.gq1.yahoo.com with NNFMP; 10 Mar 2015 19:33:33 -0000 Received: from [98.136.164.74] by tm4.bullet.mail.gq1.yahoo.com with NNFMP; 10 Mar 2015 19:33:33 -0000 Received: from [127.0.0.1] by smtp236.mail.gq1.yahoo.com with NNFMP; 10 Mar 2015 19:33:33 -0000 X-Yahoo-Newman-Id: 332378.81152.bm@smtp236.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: a4C4dpAVM1l3AYWWx5s5LI0KNDItxaQMcLVEDn17KU0Nu_0 q92HWC8o2aOE6e3SLL91sP5qSZ_ooG9D2Ogf4Fcn2H1P54MQPzZPwOOSmIIF Rm9Bh8ewYM0X2crKNuTSONm1nqpwOiaBPXce5so2Q74Eq1GKzaYJUvEYR_JE i7HOgU6sJ1hs7HJE.oCiSNusJGqqudl18SVJaC7aty7_bLAfub2Tx3wsqSAl 4_r_msEo3xXxRhupbogHX9Ojoru_LoEFBONjvLQiNbmG0uul4F9WeWTqvPyC 538xJO7CGAqCzHZXpm3b9ggQSk1qStZ8JQL0zGuWLr0I6ZPPtcipEpljgK5V 4nQdA_b9d0HfUD8c.Ua5IlUgNVrcVXLKcCog3rQc2AyvjyRQvxohCgcey0M0 Waq6RLsrLSE2mx7mRf.uqcGbK04p5ZfqOxVDHQwtk_wlbEk.EsqN2prVKoeY jF4iwsYOPPz7cJCpalLU8xqvne2VDxLArNq8TymZ.jmA5hoU8HWiJGfXgT1V VgPZKSg3ovqTQfF.Fi91Qfv.pXLXlv9CsAxY0BmaB X-Yahoo-SMTP: clhABp.swBB7fs.LwIJpv3jkWgo2NU8- Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: svn commit: r279828 - head/sys/dev/cadence From: Scott Long In-Reply-To: <201503092239.t29MdxUo089384@svn.freebsd.org> Date: Tue, 10 Mar 2015 13:33:29 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <9F60FF00-B6B4-4197-993A-9848F1C3A923@yahoo.com> References: <201503092239.t29MdxUo089384@svn.freebsd.org> To: Ian Lepore X-Mailer: Apple Mail (2.2070.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2015 19:39:51 -0000 > On Mar 9, 2015, at 4:39 PM, Ian Lepore wrote: >=20 > Author: ian > Date: Mon Mar 9 22:39:58 2015 > New Revision: 279828 > URL: https://svnweb.freebsd.org/changeset/base/279828 >=20 > Log: > Use the new ifnet API. Also, allocate bus_dma_maps as needed instead = of > pre-allocating them all at start-up. Also fix a bug in cgem_stop(); = before, > it wasn't properly unloading dma maps due to a cut-and-paste error. >=20 It=E2=80=99s generally a very bad idea to create and destroy maps for = every transaction. If the map results in being non-NULL, then you=E2=80=99re allocating and freeing = memory on every transaction, and possibly allocating and freeing large chunks of memory for bounce = buffers. Is there a reason why you=E2=80=99ve made this change? Thanks, Scott