Date: Tue, 27 Nov 2012 10:54:00 -0500 From: Eitan Adler <eadler@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Alex Kozlov <ak@freebsd.org> Subject: Re: svn commit: r307837 - head/comms/morse Message-ID: <CAF6rxgnKvqbsxXJuA0T0bNkZ%2B7c083FWZk0tn=YmLjd6JKDVdA@mail.gmail.com> In-Reply-To: <20121127155046.GA72381@FreeBSD.org> References: <201211271205.qARC54XQ060171@svn.freebsd.org> <20121127125610.GA59490@FreeBSD.org> <20121127133107.GA740@ravenloft.kiev.ua> <20121127135846.GA63249@FreeBSD.org> <20121127151842.GA5768@ravenloft.kiev.ua> <20121127155046.GA72381@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27 November 2012 10:50, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Tue, Nov 27, 2012 at 05:18:42PM +0200, Alex Kozlov wrote: >> On Tue, Nov 27, 2012 at 01:58:46PM +0000, Alexey Dokuchaev wrote: >> > On Tue, Nov 27, 2012 at 03:31:07PM +0200, Alex Kozlov wrote: >> > > I suppose I can change PA_DESC to PULSEAUDIO_DESC, but it's not really >> > > matter, because in this case specific descriptions are better and I'm not >> > > going to use generic ones from bsd.options.desc.mk. >> > >> > Yes, that was my point: use standard names, adjust default descriptions if >> > you feel that they are too generic for this particular case. >> >> Fine, I will ask maintainer if he wants to change description name >> for an aesthetic purposes. It would be minor POLA violation though, >> some users may have already set PA in make.conf. > > It is not just a matter of aesthetics, it's reducing environment pollution > with gratuitously different names of standard knobs. As for POLA, these > days people are supposed to cache their OPTIONS selection in /var/db/ports > instead of hardcoding them in /etc/make.conf. Upon upgrade, dialog will > pop up again since OPTIONS had changed, nothing should go unnoticed here. Some people do not want to use the dialog(1) interface. Using /etc/make.conf is expected and fully supported. We should not gratuitously break option names. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnKvqbsxXJuA0T0bNkZ%2B7c083FWZk0tn=YmLjd6JKDVdA>