From owner-svn-src-all@freebsd.org Sun Oct 18 07:19:51 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1AF46A18214; Sun, 18 Oct 2015 07:19:51 +0000 (UTC) (envelope-from dwmalone@maths.tcd.ie) Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [IPv6:2001:770:10:300::86e2:510b]) by mx1.freebsd.org (Postfix) with ESMTP id 0D8D16E9; Sun, 18 Oct 2015 07:19:49 +0000 (UTC) (envelope-from dwmalone@maths.tcd.ie) Received: from salmon.maths.tcd.ie (localhost [127.0.0.1]) by salmon.maths.tcd.ie (Postfix) with ESMTP id EEE931591E5; Sun, 18 Oct 2015 08:19:40 +0100 (IST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=maths.tcd.ie; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:message-id:subject:subject :from:from:date:date:received:received:received; s=20150418; t= 1445152775; x=1446967176; bh=YZf6/QWxAnMmf3JWNQn3XJAjvMc5sbwCask ljYm5Vd8=; b=u+sYxrY4SQ+2ZQ4GYp6mf/SUqhGy/j5H6FEtg5HVkld9ZFyDqbh fhN6Z8CZn6uQqR+BoV7J6df5aF7w/XrJ6QfAHQJeWRyZ/YEjVC8/EJxA8yKS0ho9 Zf4fxQFihgTAMegKLFORyHuxpPSuEMCBjstrRkkLwirM848/ffSlEUFg= X-Virus-Scanned: amavisd-new at maths.tcd.ie Received: from salmon.maths.tcd.ie ([127.0.0.1]) by salmon.maths.tcd.ie (salmon.maths.tcd.ie [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YQAvwxGhuuc1; Sun, 18 Oct 2015 08:19:35 +0100 (IST) Received: from walton.maths.tcd.ie (walton.maths.tcd.ie [IPv6:2001:770:10:300::86e2:510a]) by salmon.maths.tcd.ie (Postfix) with ESMTP id 01F151591E1; Sun, 18 Oct 2015 08:19:35 +0100 (IST) Received: by walton.maths.tcd.ie (Postfix, from userid 238) id AF6CC730AA; Sun, 18 Oct 2015 08:19:34 +0100 (IST) Date: Sun, 18 Oct 2015 08:19:34 +0100 From: David Malone To: Warner Losh Cc: Ian Lepore , Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r289421 - in head/etc: . mtree ntp Message-ID: <20151018071934.GA95077@walton.maths.tcd.ie> References: <201510161404.t9GE4GqM046436@repo.freebsd.org> <1445106350.71631.36.camel@freebsd.org> <20151017212033.GA43955@walton.maths.tcd.ie> <00150EF2-0020-42E5-A1E5-324A23975577@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00150EF2-0020-42E5-A1E5-324A23975577@bsdimp.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Oct 2015 07:19:51 -0000 Hi Warner, I was trying to check Ian's specific concern, that a valid source of leap seconds might be ignored if a expired leapseconds file was present. It seems that this is not the case, at lease based on my reading of the code and comments. I included the references to the code, so others could check if they wanted. I actually suggested configuring the leapseconds file by default to try and improve the vagueries of accepting advertised leap seconds that you mentioned. > NTP only recognizes June and December as valid leap insertion > points. Interestingly, this code seems to be gone from ntp_loopfilter.c and based on a quick look through the rest of the code, I can't see a similar general check. Some of the refclocks do retain this condition, but the general code path doesn't seem to. Possibly we should take this up with the NTP guys as a check worth retaining? David.