From owner-svn-ports-all@freebsd.org  Mon Oct  7 15:47:05 2019
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id A82C8132C6F;
 Mon,  7 Oct 2019 15:47:05 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 46n4bs40MZz4CRP;
 Mon,  7 Oct 2019 15:47:05 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [62.141.129.235])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 6B29B26012C;
 Mon,  7 Oct 2019 17:47:02 +0200 (CEST)
Subject: Re: svn commit: r513925 - in head/sysutils: . rshim-user-space
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
References: <201910070806.x9786o7L034374@repo.freebsd.org>
 <20191007081234.p2kucsd6c3erfvet@atuin.in.mat.cc>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <ab60b562-71c1-3639-99bc-0001e4972d22@selasky.org>
Date: Mon, 7 Oct 2019 17:44:39 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.0
MIME-Version: 1.0
In-Reply-To: <20191007081234.p2kucsd6c3erfvet@atuin.in.mat.cc>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 46n4bs40MZz4CRP
X-Spamd-Bar: -----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-6.00 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-0.998,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Oct 2019 15:47:05 -0000

On 2019-10-07 10:12, Mathieu Arnold wrote:
> On Mon, Oct 07, 2019 at 08:06:50AM +0000, Hans Petter Selasky wrote:
>> +PORTNAME=	rshim-user-space
>> +GH_PROJECT=	rshim-user-space
> 
> Please remove GH_PROJECT, its default value is PORTNAME.
> 
>> +PORTVERSION=	1.0
>> +GH_TAGNAME=	v1.0-alpha.1
> 
> So, PORTVERSION says 1.0 and the tag says it is an alpha release.
> PORTVERSION is probably wrong and this should have been done in its
> stead (and removing GH_TAGNAME in the process):
> 
> DISTVERSIONPREFIX=  v
> DISTVERSION=  1.0-alpha.1
> 
>> +OPTIONS_DEFAULT=
> 
> Please remove this empty variable.
> 

Will do.

Thanks for the feedback!

--HPS